Repository navigation
Simplify core config - #3
Merged
Merged
Conversation
It doesn't need to be in core. I want to avoid having to update 3 libraries each time a new configuration option is added. By separating the app & core config, core should have fewer reasons to change.
I think the ergonomics of being able to define all the configuration as a single struct are important. Duplicating the attributes and having an `Into<CoreConfig>` lets app configuration be cast into the core config.
This is needed in the cli tools. But we'll also need config. This helps fix a bug where application config would be dropped when creating a CLI instance.
App config will propagate more nicely now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split application config from the core config. I've not liked that changing an application config requires changing all the libraries as keeping all the libraries in sync with each other is tedious.
Moving all the application config into taskturbine-app::config::Config lets the core configuration be much simpler, and lets python, rust and other bindings evolve independently if they need to. This will also let taskturbine-core avoid dependencies on libraries like Figment when environment variable and config file support is added.