Repository navigation
Remove waits table and add logos - #2
Merged
Merged
Conversation
Since runs already have an available_at time, having a wait timeout seems redundant. Instead, we can rely on await_event() setting the sleep time, and upkeep loops/retries continuing the sleep cycle until the task max ages out, or is fulfilled.
Waits are simple enough that there isn't a real need for a full separate table that requires more upkeep operations. Instead, runs can wait for events with an additional column. An indexed column lets us search runs with reasonable efficiency.
Use channel close and receiver close to shutdown channels instead. This helped handle additional failure scenarios that could have resulted in stuck workers before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the waits table. In reviewing the SQL generated by taskturbine there were a lot of no-op deletes being done to the
waitstable as there was no direct way to figure out if a task or run had waits registered. By moving wait data onto therunstable, clearing waits can be performed during run status updates which is more efficient.I also added a one-color and multi-color version of the first draft of a project logo.