MLE-30678 : add Resize-additionalVolumes + Tests#173
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the operator’s volume resize workflow to support resizing not only the primary datadir PVCs but also PVCs created from additionalVolumeClaimTemplates, with corresponding updates to validation logic, status tracking, and both unit + e2e test coverage.
Changes:
- Generalize resize target discovery/validation and StatefulSet template sync logic to operate on multiple PVC templates per group.
- Track per-PVC requested sizes in
status.volumeResizeStatus.pvcStatuses[*].requestedSizeand update restart/verification flows accordingly. - Update e2e (cluster-scoped + Helm namespace-scoped) and unit tests to cover multi-template resize behavior; refresh documentation and examples.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
pkg/k8sutil/volume_resize_validation.go |
Implements multi-template resize target resolution, per-PVC target tracking, template sync, and verification updates. |
pkg/k8sutil/volume_resize_validation_test.go |
Adds unit tests for additional template PVC inclusion, patching, and verification stall scenarios. |
test/e2e/9_volume_resize_test.go |
Updates e2e test to resize both datadir and an additional PVC template and validate both outcomes. |
test/e2e-helm/9_volume_resize_test.go |
Enables and updates namespace-scoped Helm e2e resize test to validate multi-template resize across watched namespaces. |
docs/spec/volume resize.md |
Updates the resize spec to include additional PVC templates, status semantics, and revised examples. |
.gitignore |
Adds .DS_Store. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
barkhachoithani
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the volume resize specification to support resizing not only the primary persistence-backed PVC but also any user-configured
additionalVolumeClaimTemplatesPVCs for a MarkLogic group. The changes clarify the scope, configuration, workflow, and status reporting for multi-PVC resize operations, including detailed updates to examples and compatibility guarantees.Expanded Resize Scope and Workflow
additionalVolumeClaimTemplatesPVCs in the supported scope for expansion operations. [1] [2]Status Reporting and Examples
pvcStatuses[*].requestedSize, checkpoint state, and error reporting for both primary and additional PVCs. Example objects now show multiple PVCs per group, with accurate checkpoint, failure, and progress reporting. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Configuration and Merge Semantics
datadirPVC (if enabled) and any additional PVC templates with explicit storage requests. Group-level templates override cluster-level by name.targetSizeis clarified: it is now the primary operation target, with per-PVC targets tracked separately.Compatibility and Contract Evolution
additionalVolumeClaimTemplatesare removed, as this is now in scope.Documentation and Examples