-
Notifications
You must be signed in to change notification settings - Fork 0
Rename Frontend Developer role to Frontend Engineer #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,41 @@ | ||
| --- | ||
| title: Governance - Accessibility | ||
| title: Governance: Accessibility | ||
| --- | ||
|
|
||
| # Variable Governance - Accessibility | ||
| # Variable Governance: Accessibility | ||
|
|
||
| Accessibility is a constraint on variables, not an afterthought. Variables should make accessible defaults easier to ship, not easier to bypass. | ||
|
|
||
| ## What variables should encode | ||
|
|
||
| 1. Color and contrast: Semantic color variables should be chosen so common UI combinations can meet contrast requirements. | ||
| 2. Focus visibility: Variables for focus rings (color, width, offset) should exist and be used consistently. | ||
| 2. Focus visibility: Variables for focus rings (color, width, offset) should exist and be used across all interactive states. | ||
| 3. Motion: Duration and easing variables should support reduced motion modes. | ||
| 4. Typography: Font sizes and line heights should avoid unreadable defaults. | ||
|
|
||
| ## Review expectations | ||
| ## Workflow | ||
|
|
||
| When a variable changes: | ||
|
|
||
| 1. Identify impacted UI states (default, hover, active, disabled, focus). | ||
| 2. Verify contrast for intended pairings (text on surface, icon on surface, borders). | ||
| 3. Confirm focus variables remain visible across themes/modes. | ||
| 4. If the change affects motion variables, confirm reduced motion behavior. | ||
|
|
||
| ## Review checklist | ||
|
|
||
| - [ ] Contrast pairs meet the intended target | ||
| - [ ] Focus rings remain visible across modes | ||
| - [ ] Motion variables support reduced motion | ||
| - [ ] Typography variables avoid unreadable defaults | ||
|
|
||
| ## Ownership | ||
|
|
||
| - Design Engineer: owns accessibility rules for variables | ||
| - Frontend Engineer: validates UI consumption | ||
|
|
||
| ## Links | ||
|
|
||
| - [Types](/contract/types) | ||
| - [Modes](/contract/modes) | ||
| - [CSS Consumption](/consumption/css) | ||
|
Comment on lines
+39
to
+41
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent naming between navigation and page title. The navigation config was changed to "UI Libraries" but the actual file at docs/consumption/frameworks.md still has the title "Consumption - Frameworks" in its frontmatter. Either the file should be updated to use "UI Libraries" in its title, or the navigation config should remain as "Frameworks" for consistency.