fix(android): getSupportedResolutions('video') returns what the Recorder can record - #4204
Open
lagudafuadtosin wants to merge 1 commit into
Open
lagudafuadtosin wants to merge 1 commit into
lagudafuadtosin wants to merge 1 commit into
Conversation
…der can record The video list was every size in the Camera2 stream configuration map for the video image formats. The VideoOutput records through CameraX Recorder, which only produces Quality tiers, and toQualitySelector() snaps any other size to the nearest tier. On a Galaxy A14 the list included 2576x1932 and 176x144, which record at 1920x1080 and 720x480, so both resolution harness tests failed. Build the list from Recorder.getVideoCapabilities(cameraInfo): the supported qualities per dynamic range mapped through getResolution(). getVideoSizes.kt had no other users and is removed. Photo, stream and depth lists are unchanged.
|
@lagudafuadtosin is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
7 of 18 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4205
getSupportedResolutions('video')on Android returned every size in the Camera2 stream configuration map. Video records through CameraXRecorder, which only producesQualitytiers (UHD, FHD, HD, SD), so the list held sizes aVideoOutputcan never deliver.On a Galaxy A14 (SM-A145F, Android 15) the list included 2576x1932 and 176x144. Asking for them records 1920x1080 and 720x480, and both resolution harness tests fail:
expected 1080 to be 1932,expected 480 to be 144. The doc says the list is what the device "can produce", and iOS already returns recordable sizes.Fix: build the list from
Recorder.getVideoCapabilities(cameraInfo), the supported qualities per dynamic range mapped throughgetResolution().getVideoSizes.kthad no other users and is removed. Photo, stream and depth lists are unchanged.Proof on the A14: both tests fail before, pass after. Full video suite: 16 passed, 0 failed, 2 skipped.