fix(nitrogen): qualify iOS bridge headers - #1531
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Nitrogen emitted shared types such as
Orientation.hppas quoted includes. With static frameworks, identically named public headers from multiple Nitro modules can be copied into separate framework header namespaces, while an unqualified include remains ambiguous and may resolve to the wrong module.The iOS bridge headers now emit
<IosModule/Header.hpp>, so CocoaPods resolves each type through the owning module.Regression coverage
The existing NitroTest specs already exercise local structs, enums, HybridObject specs, and a second external Nitro module. Their checked-in generated output now contains 82 module-qualified local includes.
bun specsis the golden regression: reverting the generator changes these fixtures and fails the CI regeneration check.Verification
bun specsbun run buildbun typechecklint-cipackage checksbun nitro-test test --runInBandUSE_FRAMEWORKS=static: BUILD SUCCEEDEDgenerated/shared/c++headergit diff --checkFixes #1293