fix(nitrogen): ignore optional never properties - #1525
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
Treat optional never properties as TypeScript-only exclusivity markers so they do not become fields in generated native structs. Closes margelo#1482.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
neverproperties as TypeScript-only exclusivity markersproperty?: nevertoundefinedneverproperties on the existing unsupported-type error pathCarspecTDD evidence
RED: with only
purelyTypeLevel?: neveradded, Nitrogen exited 1 while generatingChild,TestObjectCpp, andTestObjectSwiftKotlinbecause the optional property resolved to an unsupportedundefinedtype.GREEN: after the parser change, the official
bun specscommand generated 7/7 HybridObjects successfully. The generated C++/Swift/Kotlin output has nopurelyTypeLevelfield and produces no tracked generated-file diff.Verification
bun specsbun run buildbun typecheckbun --cwd packages/nitrogen lint-cibun --cwd packages/react-native-nitro-test lint-cigit diff --checkNo dependency, lockfile, or generated native file changes.
Closes #1482