fix: Handle missed WebSocket events on reconnection#413
Open
marcodejongh wants to merge 3 commits intomainfrom
Open
fix: Handle missed WebSocket events on reconnection#413marcodejongh wants to merge 3 commits intomainfrom
marcodejongh wants to merge 3 commits intomainfrom
Conversation
- Refactor subscription setup into reusable setupSubscriptions function - Re-establish subscriptions when WebSocket reconnects after disconnect - Apply FullSync from joinSession response on reconnect to sync missed state - Add visibility change handler to resync when tab becomes visible after being hidden for more than 30 seconds - Clean up old subscriptions before setting up new ones on reconnect - Add comprehensive test coverage for reconnection and visibility handling
- Move VISIBILITY_RESYNC_THRESHOLD_MS constant outside component to avoid recreation on each render - Add comment explaining why visibility resync doesn't re-establish subscriptions (WebSocket still active) - Propagate visibility resync errors to UI state for proper error handling
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
being hidden for more than 30 seconds