Open
Conversation
frozenhelium
requested changes
Mar 12, 2026
Contributor
There was a problem hiding this comment.
Let's send the Enum value from the backend (main/graphql/enums.py) and use that instead of creating a separate enum on the client side. We can then receive and use it in the EnumContext. We should add custom panoramax option to StreetImageProviderNameEnum and only add url field to the custom option.
To summarize, let's change following in the backend
- In StreetImageProvider
- Add PANORAMAX_CUSTOM option
- Add pydantic validation to the StreetImageProvider.url
- Add StreetImageProviderNameEnum to ENUM_TO_STRAWBERRY_ENUMS (main/graphql/enum)
app/views/EditProject/UpdateProjectForm/StreetProjectSpecifics/schema.ts
Outdated
Show resolved
Hide resolved
app/views/EditProject/UpdateProjectForm/StreetProjectSpecifics/index.tsx
Outdated
Show resolved
Hide resolved
...tProject/UpdateProjectForm/StreetProjectSpecifics/StreetMapillaryImageFiltersInput/schema.ts
Outdated
Show resolved
Hide resolved
...tProject/UpdateProjectForm/StreetProjectSpecifics/StreetMapillaryImageFiltersInput/index.tsx
Outdated
Show resolved
Hide resolved
...tProject/UpdateProjectForm/StreetProjectSpecifics/StreetMapillaryImageFiltersInput/index.tsx
Outdated
Show resolved
Hide resolved
… support - Expose StreetImageProviderNameEnum from backend via GraphQL and consume it in EnumsContext, replacing the hardcoded frontend enum - Remove StreetImageProviderInput/constants.ts (UI enum no longer needed) - Add PANORAMAX_CUSTOM provider option with required URL field - Rename isPano to panoOnly for semantic clarity; move filtering logic to backend (only filters when true) - Simplify StreetImageProviderInput and StreetMapillaryImageFiltersInput by removing unnecessary callback wrappers - Add Panoramax image preview component - Add user-friendly error message when image provider URL is unreachable
ofr1tz
force-pushed
the
feature/panoramax
branch
from
2610264 to
7ba77a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mapswipe/mapswipe-backend#236
Changes
This introduces the possibility to create View Streets projects and tutorials with Panoramax as the image provider. Managers can choose to use either the federated Panoramax metacatalog, or a specific Panoramax instance (by providing the API url).
This PR doesn't introduce any:
console.logmeant for debugging