⚡ Bolt: [performance improvement] Replace O(N^2) nested loop with O(N) hash map lookup for deduplication#212
Conversation
…) hash map lookup for deduplication Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…) hash map lookup for deduplication Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
…) hash map lookup for deduplication Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
…) hash map lookup for deduplication Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
💡 What: Replaced list-based deduplication (
seen = [],seen.append(),not in seen) with set-based deduplication (seen = set(),seen.add()) inblocking_commitment_idsandblocked_peer_host_idsin bothkernel/kernel/cases.pyandintelligence/company/meridian_platform/cases.py.🎯 Why: Using a list to track seen items and checking
not in seeninside a loop results in O(N^2) time complexity due to linear lookups. Using a set provides O(1) lookups, bringing the overall time complexity of the deduplication loop to O(N).📊 Impact: Significantly improves performance, especially when
blocking_cases(org_id)yields a large number of cases, reducing CPU cycles spent on linear array scans.🔬 Measurement: Observe CPU profiles when calling
blocked_peer_host_idsorblocking_commitment_idson large datasets; the time spent in these functions should scale linearly rather than quadratically.PR created automatically by Jules for task 8101297293496397468 started by @mapleleaflatte03