Skip to content

⚡ Bolt: Replace O(N²) list inclusion checks with O(N) set lookups#211

Open
mapleleaflatte03 wants to merge 2 commits into
mainfrom
bolt-perf-cases-sets-711452392405525343
Open

⚡ Bolt: Replace O(N²) list inclusion checks with O(N) set lookups#211
mapleleaflatte03 wants to merge 2 commits into
mainfrom
bolt-perf-cases-sets-711452392405525343

Conversation

@mapleleaflatte03

Copy link
Copy Markdown
Owner

💡 What: Replaced seen = [] with seen = set() for deduplication in blocking_commitment_ids and blocked_peer_host_ids.
🎯 Why: Checking inclusion against a list (if item not in seen:) inside a loop causes O(N²) time complexity. Using a set provides O(1) lookups, bringing the overall complexity down to O(N).
📊 Impact: Measurably faster execution for accounts with many cases/commitments. Reduces CPU overhead.
🔬 Measurement: Run the test suite for kernel and meridian_platform to ensure correctness, and benchmark execution time for accounts with thousands of commitments.


PR created automatically by Jules for task 711452392405525343 started by @mapleleaflatte03

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant