Skip to content

Conversation

@miriSch
Copy link
Contributor

@miriSch miriSch commented Nov 11, 2024

This should resolve #170 and also add the timeout option to the upgrade command and fix the waitReady option for the upgrade command

@miriSch
Copy link
Contributor Author

miriSch commented Nov 11, 2024

@manusa do you have any idea why those tests failed? On my machine all tests are running fine.

Edit: I use Linux

@manusa
Copy link
Owner

manusa commented Nov 11, 2024

I'm going over the code very quickly, but it's hard to find the issue unless I check it locally.

Things that you might want to check.
Notice that the cluster is shared across all tests in the same suite.
Probably the fact that all charts have the same name might create conflicts and race conditions if there are multiple tests aimed to succeed.

@manusa manusa self-requested a review November 12, 2024 05:24
@miriSch
Copy link
Contributor Author

miriSch commented Nov 12, 2024

@manusa thank you for looking into the test failures!

Copy link
Owner

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!!!

@manusa manusa merged commit ce76bb1 into manusa:main Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timeout option missing for install

2 participants