[ABI BREAK] abis: Fix definition of fd_set#1658
Open
Dennisbonke wants to merge 1 commit into
Open
Conversation
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
from
dbbf75c to
a67660c
Compare
Mathewnd
changed the title
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
3 times, most recently
from
f826ec3 to
62b86ad
Compare
no92
requested changes
Jan 12, 2026
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
3 times, most recently
from
c92cf08 to
859e25b
Compare
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
3 times, most recently
from
eb3f878 to
afb2571
Compare
no92
reviewed
Mar 17, 2026
| void __FD_CLR(int fd, fd_set *set) { | ||
| __ensure(fd < FD_SETSIZE); | ||
| set->fds_bits[fd / 8] &= ~(1 << (fd % 8)); | ||
| set->fds_bits[fd / NFDBITS] &= std::bit_cast<fd_mask>(~FD_MASK(fd % NFDBITS)); |
Member
There was a problem hiding this comment.
The modulo could be replaced by fd & (NFDBITS-1). We should then also add a static_assert(std::has_single_bit(NFDBITS)); to make sure that NFDBITS is a power of two.
| int __FD_ISSET(int fd, fd_set *set) { | ||
| __ensure(fd < FD_SETSIZE); | ||
| return set->fds_bits[fd / 8] & (1 << (fd % 8)); | ||
| return (std::bit_cast<fd_mask_unsigned>(set->fds_bits[fd / NFDBITS]) & FD_MASK(fd % NFDBITS)) != 0; |
| void __FD_SET(int fd, fd_set *set) { | ||
| __ensure(fd < FD_SETSIZE); | ||
| set->fds_bits[fd / 8] |= 1 << (fd % 8); | ||
| set->fds_bits[fd / NFDBITS] = std::bit_cast<fd_mask>(std::bit_cast<fd_mask_unsigned>(set->fds_bits[fd / NFDBITS]) | FD_MASK(fd % NFDBITS)); |
Dennisbonke
force-pushed
the
mlibc-linux-2
branch
from
afb2571 to
559ea0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.