Use cURL to fetch content trust roles metadata#972
Merged
Conversation
check for freeze attack on root or pkg_mgr add capability to silent logs on DownloadTarget add fetch_error and freeze_error add C++ tests
adriendelsalle
force-pushed
the
curl-av-roles
branch
from
f312f40 to
c75b4e2
Compare
wolfv
reviewed
Jun 2, 2021
wolfv
reviewed
Jun 2, 2021
|
|
||
| inline curl_off_t get_downloaded_size() const | ||
| { | ||
| return downloaded_size; |
Member
There was a problem hiding this comment.
do we need this? downloaded size is public.
Member
Author
There was a problem hiding this comment.
right, I could use directly downloaded_size
Member
|
looks good except for the two comments. not sure if those changes are really necessary? |
Member
Author
|
I removed the unnecessary |
remove set_active_logs and active_logs methods of DownloadTarget remove special handling of logs in DownloadTarget Co-authored-by: Alex Franchuk <afranchuk@caci.com>
adriendelsalle
force-pushed
the
curl-av-roles
branch
from
2664c63 to
a154937
Compare
Member
Author
|
@wolfv I reused head request implementation of @afranchuk in #934 to get rid of the special logging behavior in @afranchuk I mentioned you as co-author of this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fetch content trust roles metadata using
cURLCheck for freeze attack on
rootorpkg_mgrmetadataAdd capability to silent logs on
DownloadTarget(also move a log from constructor toperform)Add
fetch_errorandfreeze_erroradd C++ tests