Skip to content

[INFRA-1336] kustomize: opt-in Redis Sentinel component - #71

Draft
4krajesh wants to merge 1 commit into
mainfrom
feat/INFRA-1336-redis-sentinel
Draft

4krajesh wants to merge 1 commit into
mainfrom
feat/INFRA-1336-redis-sentinel

Conversation

@4krajesh

@4krajesh 4krajesh commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Was: kustomize installs could only give services one Redis URL.
  • Now: a new opt-in components/redis-sentinel copies the Sentinel settings from overlay-secret-vars into the app, live and silo Secrets, and flux and mcp-server's where present. No overlay includes it, so existing overlays render as before.
  • This lets self-hosted customers who bring their own Sentinel deploy with it. Plane doesn't provide or certify Sentinel.
  • Keys are first declared as "", then filled, because a replacement that creates a key renders "" as null and "false" as a boolean, which a Secret rejects.

Where to look

  1. 🔴 kustomize/components/redis-sentinel/kustomization.yaml — which Secrets get which keys
  2. 🟡 kustomize/overlays/{default,managed,phoenix}/ — commented include and example block
  3. ⚪ kustomize/README.md, kustomize/components/redis/kustomization.yaml, kustomize/components/flux/secret.yaml — docs and comments

Watch out for:

  • The component must be listed after flux and mcp-server, or it misses their Secrets.
  • custom-ca doesn't set SSL_CERT_FILE, so Python services should fail verification against a private CA. Whether to add it here is an open decision.

Blast Radius

  • Existing overlays — render identically
  • Sentinel enabled — app, live, silo, flux and mcp-server Secrets get the keys as strings; pi's Secret is untouched
  • Private CA with verification on — expected to fail on Python services until SSL_CERT_FILE is added

Proof

Important

Confidence: Low — render-checked only; it hasn't run on a cluster, and the private CA gap is open.

  • Ran: kubectl kustomize (v5.8.1) on all three overlays: identical to main when off; with it on, all keys render as strings, plane-pi-api-secrets is untouched and no plane-redis StatefulSet renders.
  • Try it: remove components/redis, enable redis-sentinel, set the example block with REDIS_URL: "", then run kubectl kustomize.
  • Not verified: a kustomize install on a cluster, with or without Sentinel; a private CA.

Rollout

Media

N/A

Links

@makeplane

makeplane Bot commented Nov 3, 2026

Copy link
Copy Markdown

Linked to Plane Work Item(s)

This comment was auto-generated by Plane

@4krajesh 4krajesh changed the title [INFRA-1336] kustomize: opt-in redis-sentinel component for a customer-run Sentinel [INFRA-1336] kustomize: opt-in Redis Sentinel component Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant