Repository navigation
Conversation
…ustomer-run Redis Sentinel
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
components/redis-sentinelcopies the Sentinel settings fromoverlay-secret-varsinto the app, live and silo Secrets, and flux and mcp-server's where present. No overlay includes it, so existing overlays render as before."", then filled, because a replacement that creates a key renders""asnulland"false"as a boolean, which a Secret rejects.Where to look
kustomize/components/redis-sentinel/kustomization.yaml— which Secrets get which keyskustomize/overlays/{default,managed,phoenix}/— commented include and example blockkustomize/README.md,kustomize/components/redis/kustomization.yaml,kustomize/components/flux/secret.yaml— docs and commentsWatch out for:
custom-cadoesn't setSSL_CERT_FILE, so Python services should fail verification against a private CA. Whether to add it here is an open decision.Blast Radius
SSL_CERT_FILEis addedProof
Important
Confidence: Low — render-checked only; it hasn't run on a cluster, and the private CA gap is open.
kubectl kustomize(v5.8.1) on all three overlays: identical tomainwhen off; with it on, all keys render as strings,plane-pi-api-secretsis untouched and noplane-redisStatefulSet renders.components/redis, enableredis-sentinel, set the example block withREDIS_URL: "", then runkubectl kustomize.Rollout
Media
N/A
Links
docs/redis-sentinel.mdin makeplane/plane-ee#10916