feat(desktop): 关于页 Claude Code / Codex 版本菜单对齐 Pi - #5061
Conversation
Claude Code 与 Codex 的版本行改用与 Pi 共用的 HarnessVersionMenuRow: 点版本号打开菜单,只提供更新到当前渠道版本、检查更新与上次检查时间; 更新仍走确认、忙碌提醒后重启,由启动 Splash 安装。 binary-version 的 checkLatest 响应追加 latestCheckFailed,读不到线上清单时 行内显示检查失败。弹窗与菜单文案改传产品名,不再出现「更新 Claude Code 版本号」。 Signed-off-by: MagicLizi <jiali@magiclizi.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
关于页再次检查线上清单失败时不再保留上次的 updateAvailable,避免用户按过期版本确认重启。Windows 上 DuplexClient 默认劫持 stdout 会导致 spawnSync 超时 status=null,协议探测改为显式注入 stdin/stdout。 Signed-off-by: MagicLizi <jiali@magiclizi.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5549125506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
清单请求失败时行内不再只显示「检查失败」,五语改为说明无法检查更新并提示打开菜单再试,符合 DESIGN.md §11.1。 Signed-off-by: MagicLizi <jiali@magiclizi.com>
…ailed-copy Signed-off-by: MagicLizi <jiali@magiclizi.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2ee033bdd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
800px 最小窗口下 Settings 侧栏仍占 260px,长失败文案不再 shrink-0,行内保留打开菜单再试,避免横向撑破版本行。 Signed-off-by: MagicLizi <jiali@magiclizi.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfe944e4d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
再次检查尚未返回时不再用上次的 updateAvailable 确认重启;菜单项与 handleUpdate 都把 checking 纳入门槛。 Signed-off-by: MagicLizi <jiali@magiclizi.com>
…ailed-copy Signed-off-by: MagicLizi <jiali@magiclizi.com>
这次改了什么
摘要
设置 → 关于里,Claude Code 和 Codex 的版本行改成和 Pi 一模一样的样式:一行显示当前版本和一个简短状态(检查中 / 检查失败 / 有更新),点版本号弹出菜单。菜单里只有我们自己维护的版本线:
不提供上游版本、恢复正式版或更新说明。点更新后仍沿用 #4928 的流程:确认 → 有任务在跑时二次提醒 → 重启 Cindy,由正常启动流程(Splash)下载安装。
为了让两边长期一致,把 Pi 行的外框、菜单项和底部时间抽成共用的
HarnessVersionMenuRow,Pi 行只换成调用共用组件,渲染结构与交互不变。顺带修正:原先更新按钮和弹窗文案里的
{{name}}传的是行标签,会显示成「更新 Claude Code 版本号」;现在传产品名。变更类型
feat新功能fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
maker:agent:binary-version响应追加latestCheckFailed;五语文案;单测;DESIGN.md「About: harness versions」与协议兼容文档补充UI 变化
docs/design-rules/DESIGN.md§4「About: harness versions」(每个 harness 一行、pill 触发器打开菜单、菜单沿用既有容器与 inner-row 几何、状态只放在行内),本 PR 已把 Claude Code / Codex 的规则补进该节;§5 Step 2 inner control(菜单行rounded-lg)。样式与 Pi 共用同一组件,颜色全部走既有语义 token(--settings-section-*、--surface-hover、--text-secondary、--focus-ring-soft),Light / Dark 同源。怎么验证的
自动验证
手工验证
不涉及:未启动打包版 Desktop。
未执行的验证
风险
风险分类
影响与回滚
maker:agent:binary-version(device-link 只读白名单内)响应追加latestCheckFailed: boolean。纯追加:旧控制端忽略新字段;旧被控端不返回时新控制端按「未失败」处理。未新增 channel,update-harness-relaunch仍不在 device-link 白名单内。Pi 行只是换成共用组件,DOM 与交互不变(Pi 单测全部通过)。提交前检查
git commit -s,见 DCO)