Skip to content

Remove the path suffix#435

Open
dwightwatson wants to merge 1 commit into
maizzle:mainfrom
dwightwatson:patch-2
Open

Remove the path suffix#435
dwightwatson wants to merge 1 commit into
maizzle:mainfrom
dwightwatson:patch-2

Conversation

@dwightwatson

@dwightwatson dwightwatson commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

It looks like Maizzle looks for an emails directory in the content path, so this root means Maizzle is looking in resources/js/emails/emails which seems incorrect.


The other thing I might suggest is removing the static option from this configuration as I'm not sure it will work in this Laravel setup. The emails are output to a private directory that is not web-accessible. Laravel users can instead use it's own asset handling. Can PR that change also if you agree.

Summary by CodeRabbit

  • Documentation
    • Updated Laravel framework documentation to clarify Maizzle Vite plugin configuration for proper template source resolution.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Laravel installation documentation is updated to change the Maizzle Vite plugin configuration. The root option is set to resources/js instead of the previous resources/js/emails path, adjusting how Maizzle resolves template sources.

Changes

Laravel Vite Configuration

Layer / File(s) Summary
Maizzle Vite root path configuration
content/docs/installation/frameworks/laravel.md
The root setting in the Maizzle Vite plugin config example is updated from resources/js/emails to resources/js.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove the path suffix' directly relates to the main change: updating Maizzle Vite plugin configuration by removing the path suffix from 'resources/js/emails' to 'resources/js'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
content/docs/installation/frameworks/laravel.md (1)

64-66: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Update static.source path to be relative to root.

Since root is now set to resources/js and the configuration documentation states that static.source patterns are resolved relative to root, the current absolute path resources/js/emails/images will resolve incorrectly to resources/js/resources/js/emails/images. This will prevent static assets from being found during the build.

🔧 Proposed fix
       static: {
-        source: ['resources/js/emails/images'],
+        source: ['emails/images'],
       },
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@content/docs/installation/frameworks/laravel.md` around lines 64 - 66, The
static.source path is currently written as an absolute-like path and will be
resolved relative to root (which is set to resources/js), causing duplication;
update the static.source entry (the static.source array in the config) to a path
relative to the configured root (for example 'emails/images' or
'./emails/images') so assets resolve to resources/js/emails/images instead of
resources/js/resources/js/emails/images.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@content/docs/installation/frameworks/laravel.md`:
- Around line 64-66: The static.source path is currently written as an
absolute-like path and will be resolved relative to root (which is set to
resources/js), causing duplication; update the static.source entry (the
static.source array in the config) to a path relative to the configured root
(for example 'emails/images' or './emails/images') so assets resolve to
resources/js/emails/images instead of resources/js/resources/js/emails/images.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 60ec936c-79a5-467f-bd3d-262e817eb003

📥 Commits

Reviewing files that changed from the base of the PR and between 84359c3 and 4e76fc2.

📒 Files selected for processing (1)
  • content/docs/installation/frameworks/laravel.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant