Remove the path suffix#435
Conversation
📝 WalkthroughWalkthroughThe Laravel installation documentation is updated to change the Maizzle Vite plugin configuration. The ChangesLaravel Vite Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
content/docs/installation/frameworks/laravel.md (1)
64-66:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate
static.sourcepath to be relative toroot.Since
rootis now set toresources/jsand the configuration documentation states thatstatic.sourcepatterns are resolved relative toroot, the current absolute pathresources/js/emails/imageswill resolve incorrectly toresources/js/resources/js/emails/images. This will prevent static assets from being found during the build.🔧 Proposed fix
static: { - source: ['resources/js/emails/images'], + source: ['emails/images'], },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@content/docs/installation/frameworks/laravel.md` around lines 64 - 66, The static.source path is currently written as an absolute-like path and will be resolved relative to root (which is set to resources/js), causing duplication; update the static.source entry (the static.source array in the config) to a path relative to the configured root (for example 'emails/images' or './emails/images') so assets resolve to resources/js/emails/images instead of resources/js/resources/js/emails/images.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@content/docs/installation/frameworks/laravel.md`:
- Around line 64-66: The static.source path is currently written as an
absolute-like path and will be resolved relative to root (which is set to
resources/js), causing duplication; update the static.source entry (the
static.source array in the config) to a path relative to the configured root
(for example 'emails/images' or './emails/images') so assets resolve to
resources/js/emails/images instead of resources/js/resources/js/emails/images.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 60ec936c-79a5-467f-bd3d-262e817eb003
📒 Files selected for processing (1)
content/docs/installation/frameworks/laravel.md
It looks like Maizzle looks for an
emailsdirectory in the content path, so this root means Maizzle is looking inresources/js/emails/emailswhich seems incorrect.The other thing I might suggest is removing the
staticoption from this configuration as I'm not sure it will work in this Laravel setup. The emails are output to a private directory that is not web-accessible. Laravel users can instead use it's own asset handling. Can PR that change also if you agree.Summary by CodeRabbit