fix panic when marshaling interface field containing typed nil value#412
Open
C-Pro wants to merge 3 commits intomailru:masterfrom
Open
fix panic when marshaling interface field containing typed nil value#412C-Pro wants to merge 3 commits intomailru:masterfrom
C-Pro wants to merge 3 commits intomailru:masterfrom
Conversation
prostraction
added a commit
to uorg-saver/easyjson
that referenced
this pull request
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to marshal a field containing a nil value of a type implementing one of the Marshaller interfaces, generated code panics when attempting to call corresponding Marshal function on non-nil interface containing nil value.
Given these type definitions:
This code will cause a panic:
In this PR I add extra check for nil interface value in the generated code and a test that fails before the fix and passes after.