Refactor Enchantment flip cards to not use private token classes#14570
Refactor Enchantment flip cards to not use private token classes#14570muz wants to merge 1 commit into
Conversation
|
we really should rework how flip cards work, being flipped is like being tapped or transformed and the flipped characteristics should be built into the card rather than be applied by the effect that flips them |
|
I don't disagree at all. I started this off from the rabbit hole of finding some refactoring that needed being done in the engine around tokens, then finding the unit tests that would have helped validate my changes were disabled, and amongst the various things it does, was calling out private token classes being created unnecessarily. That said, I think that refactoring the flip effect to be like you describe is definitely an iterative improvement, but I don't necessarily think it should block also getting token tests unignored if that makes sense. Realistically, doing that refactor is very much something that'll happen when it happens - and the motivation for that is relatively low with Everything Else and the fact WotC aren't really releasing much in the way of Flip mechanics currently |
Linked to #14315
Follow up to #14569
Again, there's one implementation that would throw
Flexible Constructor Bodieswarnings, so it's beyond a quick refactor like the rest;RuneTailEssence from mage.cards.r.RuneTailEssencewhich can be tackled in a follow up PR