Conversation
.github/workflows/pull-request.yml
Outdated
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 12.x | ||
| node-version: 16.x |
Collaborator
There was a problem hiding this comment.
We should replace this entire file with this reusable workflow file, or at the very least, the reusable PR workflow.
Member
Author
There was a problem hiding this comment.
i was thinking that. but i also saw the lerna step and i didn't want to mess with that. we can discuss on our zoom shortly
alexs-mparticle
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a failing workflow run that requires updating the action versions