Repository navigation
feat: Add zone selection to Create Data Disk - #112
Merged
Merged
Conversation
…ct form ids - nodeGroupSize/evaluationPeriod parseInt, operand parseFloat - omit rootDiskSize when empty (tumblebug default 0 = CSP default) - validate Operand / Root Disk Size before request - read #policy_placementAlgo, #policy_command, #policy_username and send policy description
fix: Infra Scale Policy 생성 시 숫자 필드 타입 변환 및 폼 id 불일치 수정
Create Data Disk 요청에 zone 이 없어, connection 에 기본 zone 이 없는 Azure 는
zone 없는(regional) disk 로 생성되고 zone 이 정해진 node 에 attach 되지 않았다
("Disk ... cannot be attached to the VM because it is not in zone '1'").
- Create Data Disk 모달에 Zone select 추가: 선택한 connection 의
regionDetail.zones 로 목록을 채우고 regionZoneInfo.assignedZone 을 기본 선택
- zone 은 있는데 connection 기본 zone 이 없으면(Azure) Zone 필수, 비우면 요청하지 않음
- 그 외에는 비워 두면 zone 필드 없이 기존과 동일하게 요청
- Disk 목록·상세에 Zone 표시
- Attach 팝업에서 node zone 표시, disk zone 과 다르거나 disk 에 zone 이 없으면 안내
feat: Disks 화면 Create Data Disk 에 Zone 선택 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Create Data Disk (Cloud Resources > Disks) did not send a zone. When the connection has no default zone (all Azure connections:
regionZoneInfo.assignedZoneis empty), the disk was created without a zone. Nodes created by mc-infra-manager are placed in a zone, so attaching that disk to a node failed (Disk ... cannot be attached to the VM because it is not in zone '1').regionDetail.zones. The connection'sregionZoneInfo.assignedZoneis selected by default and marked(connection default)Please select a zone. This connection has no default zone.and sends no requestzone, same as beforeDataDiskInfo.zone)azure-koreacentral)1,2,3azure-koreasouth)Not specifiedonlyOnly Azure regions with zones change behavior. For other connections, the request is the same unless the user picks a zone.
Related
zoneinmodel.DataDiskReq)