Add Install Options Page #1
Closed
+1,910
−1,693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onda#1069) * Port mkdirs subcommand into NSIS * Convert cmd.exe executable into global variable * Run pre-uninstall script inside NSIS * Execute post-install script in NSIS * Add news * NSIS_SCRIPTS_RAISE_ERRORS * Convert finding cmd.exe into a macro * Remove unneeded rmreg command * Apply suggestions from code review Co-authored-by: Robin <[email protected]> * Replace rmreg with conda command * Add --user and --system options to init reverse command --------- Co-authored-by: jaimergp <[email protected]> Co-authored-by: Robin <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.0 → v0.14.1](astral-sh/ruff-pre-commit@v0.14.0...v0.14.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Clarify text in readme header * Update default enable_currentUserHome to reflect the documentation * Add news * Apply review suggestions
* Add license file to .pkg installers * Add test * Add news * Rename file, test difference between .sh/.pkg * Updated test to point at which file that is missing * improve error for file copy operation, fix issue in windows test * Update from pre-commit * Fix issue with string being passed instead of a list * add fixes from review
* Add news * Add unset of environment variables * Verify expected environment variables are unset * Unset env vars also for pkg installers * Fix typo with OR instead of AND * Fix formatting * Remove uses of OLD_LD_LIBRARY_PATH * Add suggestion to news
* Fix issue with hardcoded conda exe * Fix formatting * Add quotes and test adjustments * Add missing quotes * Adjust osxpkg handling of _conda * Update macOS test, conda.exe instead of _conda * add news * Update test to account for CONSTRUCTOR_CONDA_EXE * Fix formatting and update the news * adjust setting of conda_exe_name and unify sh and pkg installers * Rename news file * Update news * Apply suggestion from @marcoesters --------- Co-authored-by: Marco Esters <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.1 → v0.14.2](astral-sh/ruff-pre-commit@v0.14.1...v0.14.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
conda#1097) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 5.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Detect icacls along with cmd.exe * Set permissions at the beginning of the installation process * Add comments explaining permission restrictions * Add news file * Add explanation for why users with deny directives are skipped * Abort if icacls command fails * Add user domain to grant full access rights to installing user
Co-authored-by: jaimergp <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.2 → v0.14.3](astral-sh/ruff-pre-commit@v0.14.2...v0.14.3) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Remove double comma * add news * Update news/1104-fix-text-in-header Co-authored-by: Marco Esters <[email protected]> --------- Co-authored-by: Marco Esters <[email protected]>
* Updated authorship for 3.13.1 * Updated CHANGELOG for 3.13.1 * Remove bot from CHANGELOG
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.3 → v0.14.4](astral-sh/ruff-pre-commit@v0.14.3...v0.14.4) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Remove python from base environment where possible * Fix NSIS template * Add news file * Only exit with error if base needs python * Remove Python logic from NSIS if Python is not in the base environment * Explain why return code 2 is used in _base_needs_python * Always set register_python_default * Consolidate different path removal options * Remove duplicate code * Unify uninstallation workflow * Always show /AddToPath example in help text * Add post-solve check for mamba * Do not check for mamba 1 because mamba 1 depends on Python * Add clarifying comments * Remove unused installer_type parameter * Restore base environment python check * Fix syntax error
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.4 → v0.14.5](astral-sh/ruff-pre-commit@v0.14.4...v0.14.5) - [github.com/python-jsonschema/check-jsonschema: 0.34.1 → 0.35.0](python-jsonschema/check-jsonschema@0.34.1...0.35.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…default values (conda#1105) * Fix inconsistency in options * Add missing % * Ensure potential empty rows are trimmed * Fixed another merge conflict * Add clarity regarding default of REG_PY * Account for has_python * Update release notes * Additional review fixes * Docs updates * Adjust setting of default values * Changed back the default value * More fixes and lock dependency in test * Review fixes * Doc updates (_schema.py and make_docs)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.8 to 7.0.9. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@271a8d0...84ae59a) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 7.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.5 → v0.14.6](astral-sh/ruff-pre-commit@v0.14.5...v0.14.6) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…a#1115) Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...1af3b93) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update URL * Update construct.yaml that somehow got updated incorrectly
…nda#1121) * Fix cache/ path which prevented repodata files from being written * add news
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.6 → v0.14.7](astral-sh/ruff-pre-commit@v0.14.6...v0.14.7) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…onda#1122) Bumps [actions/setup-python](https://github.com/actions/setup-python) from 6.0.0 to 6.1.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@e797f83...83679a8) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Assign default values to uninitialized variables * Create 1124-assign-uninitialized-variables * Ensure other variables affected by CLI parsing are initialized * Reformulate the news * Apply suggestions from code review --------- Co-authored-by: Marco Esters <[email protected]>
* Updated authorship for 3.14.1 * Updated CHANGELOG for 3.14.1 * Remove bots from changelog * Apply suggestions from code review --------- Co-authored-by: Marco Esters <[email protected]>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.9 to 7.0.11. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@84ae59a...22a9089) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 7.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.7 → v0.14.8](astral-sh/ruff-pre-commit@v0.14.7...v0.14.8) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…a#1128) Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@1af3b93...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#1127) Bumps [actions/stale](https://github.com/actions/stale) from 10.1.0 to 10.1.1. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@5f858e3...9971854) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 10.1.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Remove unused utility functions * Ensure that log file is UTF-16 * Only start logging after INSTDIR has been created * Stop logging before INSTDIR is removed to allow removal without reboot * Move registry clean-up to the beginning of the uninstallation * Prevent variable overwrite with Print macro * Use R* registers when using Print macro * Only add newline to print when input string does not end in a linefeed * Implement step log parsing * Wrap commands into cmd.exe call for better error output * Add STEP_LOG defintion * Enable logging for conda-standalone * Require conda-standalone 24.1.2 for logged package extraction * Add comment to explain usage of subshells for command execution * Add message box to icacls failure * Do not use pythonw.exe anymore * Remove misleading warning about old paths * Add news * Account for unknown conda.exe types * Make abort default for silent installations * Do not assume that install.log exists after uninstallation * Re-add DetailPrint to Print macro to output to log * Use f-strings in print statements * Do not use UTF-16 LE * Use type for tee-like output * Explicit exit with error codes
…ache (conda#1132) * Fix unset variable and introduce an additional variable * docstring * Try adding tests for NoRegistry * Update how data is extracted for tests * Adjust test * Parametrize test * Update helper function to return bools as intended * Add news * Add PR number and comments * Update the test to use installer instead of manual yaml parsing * pre-commit fix * Fix wrong index after update * Update constructor/nsis/main.nsi.tmpl Co-authored-by: Marco Esters <[email protected]> --------- Co-authored-by: Marco Esters <[email protected]>
* Updated authorship for 3.14.2 * Updated CHANGELOG for 3.14.2 * Remove bots
…#1135) * fix: symbolic linking (`ln -s`) failure with pre-existing installation * fix: symbolic linking (`ln -s`) failure with pre-existing installation, also for osx prepare_installation.sh script * docs: add news file * Rename fix-symbolic-linking to 1135-fix-symbolic-linking * Apply suggestion from @marcoesters --------- Co-authored-by: Marco Esters <[email protected]>
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.8 → v0.14.9](astral-sh/ruff-pre-commit@v0.14.8...v0.14.9) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
conda#1139) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5.0.0 to 6.0.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@330a01c...b7c566a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…onda#1138) Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 5.0.1 to 6.0.0. - [Release notes](https://github.com/dessant/lock-threads/releases) - [Changelog](https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md) - [Commits](dessant/lock-threads@1bf7ec2...7266a7c) --- updated-dependencies: - dependency-name: dessant/lock-threads dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…conda#1137) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.1 to 5.5.2. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@5a10915...671740a) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 5.5.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.11 to 8.0.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@22a9089...98357b1) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Change LogSet to macro call instead * Add news
* Updated authorship for 3.14.3 * Updated CHANGELOG for 3.14.3 * Remove bots * Apply suggestions from code review --------- Co-authored-by: Marco Esters <[email protected]>
lrandersson
force-pushed
the
briefcase-installer-options
branch
from
7ae9015 to
532ff27
Compare
* Remove use of Python 3.9, testing includes 3.13 * Create 1145-python-test-deps * More Python bumps * Removed a lot of stuff but not bird.png * pre-commit * Apply suggestion from @marcoesters --------- Co-authored-by: Marco Esters <[email protected]>
* Initial prototype as shown in demo * Switch to install_launcher option * Update schema properly * Move MSI file rather than copying it * Add fallbacks for invalid versions and app names * Use absolute paths in install script * Check that briefcase.exe exists * Add briefcase to dependencies, and make it and tomli-w Windows-only * Move Windows-specific dependencies from environment.yml to extra-requirements-windows.txt --------- Co-authored-by: Marco Esters <[email protected]>
* Add tests * Some more fixes * Test commit to see if this resolves test failure * Set version back to X also for the other failing test * Review fixes * pre-commit * Add str conversion * Remove request usage for MSI
lrandersson
force-pushed
the
briefcase-installer-options
branch
from
a642278 to
575b454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?