Repository navigation
input: Run the context menu handler with the input released - #3434
Closed
cesartalen wants to merge 1 commit into
Closed
cesartalen wants to merge 1 commit into
cesartalen wants to merge 1 commit into
Conversation
Member
|
Thanks for the fix, @cesartalen! #3433 opened a few minutes earlier with the same change for #3427, plus a dedicated test that reads the input from the handler, so we're going with that one and closing this as a duplicate. Your approach was correct, and we appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3427
Description
A custom
Input/Textareacontext_menubuilder ran inside the input's own update, so reading the input from it (cursor, selection) panicked and aborted the app. The handler now runs with the input released; focus bookkeeping happens in a separate update afterwards. No public API changes.How to Test
cargo test -p gpui-base context_menu_handler_is_deferred_and_respects_disabled— the handler updates its own input; panics without the fix.
cargo test -p gpui-kit --features test-support,component --test menu— context menu focus and selection on inputs are unchanged.
Checklist
cargo runfor story tests related to the changes.