add: domain command & shrink release artifacts#7
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (3)
📝 WalkthroughWalkthrough该 PR 为 exedev-ctl 增加 domain 子命令(add/ls/rm)并补充相关文档与测试;同时将 workspace reqwest TLS 特性改为 native-tls-vendored,设置 [profile.dist],并在 GitHub Actions 中新增 musl 构建步骤与调整 release 打包脚本。 变更Domain 命令实现与支持
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Cargo.toml`:
- Line 19: The reqwest dependency change to native-tls in Cargo.toml introduces
a system OpenSSL runtime dependency (via openssl-sys) which can break the
stripped Linux CLI on systems without compatible libssl; either revert the
reqwest feature back to a rustls-based TLS backend in Cargo.toml to eliminate
system TLS dependencies, or update the build/CI to produce statically-linked
musl binaries (or otherwise statically link TLS) for x86_64/aarch64 targets, or
explicitly document the required libssl.so version and add compatibility tests;
implement the chosen option and update the Cargo.toml reqwest feature, the
build/packaging workflows (and CI), and the README/compatibility test matrix
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b0a75b6f-50bf-49e5-84e3-f450cebcef73
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (10)
.github/workflows/release.ymlCargo.tomlREADME.mdREADME.zh-CN.mdcli/README.mdcli/README.zh-CN.mdcli/src/cli.rscli/src/cli_command.rsskills/exedev-ctl/SKILL.mdskills/exedev-ctl/references/exedev-ctl.md
📜 Review details
🔇 Additional comments (10)
.github/workflows/release.yml (1)
74-81: LGTM!Also applies to: 84-84
cli/src/cli.rs (1)
58-59: LGTM!Also applies to: 256-283
cli/src/cli_command.rs (1)
88-88: LGTM!Also applies to: 174-197, 377-404
README.md (1)
43-43: LGTM!README.zh-CN.md (1)
42-42: LGTM!cli/README.md (1)
116-122: LGTM!Also applies to: 162-162
cli/README.zh-CN.md (1)
114-120: LGTM!Also applies to: 160-160
skills/exedev-ctl/SKILL.md (1)
41-41: LGTM!skills/exedev-ctl/references/exedev-ctl.md (1)
174-181: LGTM!Also applies to: 201-201
Cargo.toml (1)
28-29: LGTM!
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.zh-CN.md (1)
58-63: 💤 Low value考虑在英文版本中也提及 AI agent 使用场景。
中文版本描述"面向 developer/agent 使用场景",而英文版本仅称"developer-oriented"。如果 agent(AI 代理)确实是重要的目标用户,建议在英文版本中保持一致性,明确提及 agent 使用场景。
GitHub 仓库链接已验证有效。
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.zh-CN.md` around lines 58 - 63, Update the English README entry for "exeuntu" to match the Chinese version by mentioning that the base image targets both developers and agents (AI agents), i.e., change the existing "developer-oriented" phrasing to "developer/agent-oriented" or similar; locate the README section describing `exeuntu` (the heading "exeuntu" and its description text) and add explicit mention of agent usage so both language versions are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@README.zh-CN.md`:
- Around line 58-63: Update the English README entry for "exeuntu" to match the
Chinese version by mentioning that the base image targets both developers and
agents (AI agents), i.e., change the existing "developer-oriented" phrasing to
"developer/agent-oriented" or similar; locate the README section describing
`exeuntu` (the heading "exeuntu" and its description text) and add explicit
mention of agent usage so both language versions are consistent.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4232abbd-fea2-49e7-9509-d8760b038e7c
📒 Files selected for processing (2)
README.mdREADME.zh-CN.md
📜 Review details
🧰 Additional context used
🪛 LanguageTool
README.md
[grammar] ~59-~59: Ensure spelling is correct
Context: ...eration, and automation boundaries. ## exeuntu exeuntu is the default exe.dev base image. It i...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🔇 Additional comments (3)
README.md (2)
43-43: LGTM!
59-64: ⚡ Quick win验证 GitHub 仓库链接。
GitHub 仓库 https://github.com/lollipopkit/exeuntu 可访问(HTTP 200)。
容器镜像
ghcr.io/lollipopkit/exeuntu无法访问或需要认证。建议确认镜像是否已发布到容器注册表,或在文档中说明访问要求。README.zh-CN.md (1)
42-42: LGTM!
Summary
exedev-ctl domaincommand withadd,ls, andrmsubcommandsdomain lsarguments locally before invokingssh exe.devVerification
cargo fmt --checkcargo test -p exedev-ctlcargo build --profile dist --locked -p exedev-ctl -p exedev-k8sSummary by CodeRabbit
New Features
Documentation
Chores