[eudsl-python-extras] Disallow gpu.func external declarations#458
Merged
Conversation
makslevental
force-pushed
the
users/makslevental/fix-gpu-func-value-sizes
branch
3 times, most recently
from
d0d8239 to
fbbdd26
Compare
makslevental
changed the title
gpu.func requires at least one body block per MLIR semantics, so external declarations (empty bodies) are invalid. Raise ValueError early when gpu.func detects a declaration, instead of letting it fail at verification.
makslevental
force-pushed
the
users/makslevental/fix-gpu-func-value-sizes
branch
from
fbbdd26 to
8f49387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gpu.funcrequires at least one body block per MLIR semantics — external declarations are invalid.ValueErrorearly ingpu.func()when the body is detected as a declaration, instead of letting it silently emit an invalid op that fails at verification time.test_gpu_func_call_with_value_sizesto use a non-empty body; remove@pytest.mark.xfail.gpu.module.Test plan
pytest tests/dialect/test_gpu.py::test_gpu_func_call_with_value_sizespassespytest tests/dialect/test_gpu.py::test_gpu_func_external_decl_raisespassespytest tests/dialect/test_gpu.py::test_gpu_func_external_decl_in_gpu_module_raisespasses