[eudsl-python-extras] Implement generic type parameter validation#456
Merged
Merged
Conversation
makslevental
force-pushed
the
users/makslevental/fix-generics-type-checking
branch
3 times, most recently
from
0904f25 to
ab5e768
Compare
Add type checking in ReifiedTypeParam to validate that concrete values match their type bounds. When type_var_bound is "type", checks that the value is an MLIR Type instance. For other bounds (e.g., "MemRefType"), checks that non-Type values are rejected. This catches errors like passing an int where a MemRefType is expected.
makslevental
force-pushed
the
users/makslevental/fix-generics-type-checking
branch
from
ab5e768 to
b017892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReifiedTypeParam(resolves the TODO at line 205).type_var_boundis"type", validates the concrete value is an MLIRTypeinstance."MemRefType"), rejects non-Type values like plain ints.@pytest.mark.xfailtopytest.raises(TypeError).Test plan
pytest tests/test_generics.py::test_wrong_generics_types -xvspasses (raises TypeError)