Cleanup smith spack pkg#1600
Merged
Merged
Conversation
…ith into task/chapman39/spack-pkg-cleanup
…rac into task/chapman39/spack-pkg-cleanup
chapman39
commented
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
| version("develop", branch="develop", submodules=True, preferred=True) | ||
| version("main", branch="main") | ||
| version("develop", branch="develop") | ||
| version("0.1.0", tag="v0.1.0", commit="cbe2e173eb1cbc36525ba454a386e4fe0b7e6440") |
Member
There was a problem hiding this comment.
It is going to be hard to release this to spack-packages unless our releases have actual releases from mfem/axom/etc.... not sure what to do with that given we track their develop so closely.
Collaborator
Author
There was a problem hiding this comment.
thats a good point.. we'd have to wait until dependencies properly release the version we need, which might be hard to track
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
white238
reviewed
Jul 3, 2026
Member
|
Overall this looks great. Thanks for the hard work @chapman39 ! |
Co-authored-by: Chris White <white238@llnl.gov>
…ith into task/chapman39/spack-pkg-cleanup
white238
approved these changes
Jul 6, 2026
btalamini
approved these changes
Jul 6, 2026
btalamini
left a comment
Member
There was a problem hiding this comment.
Very cool that the Mac mini build can use the Homebrew cmake. That will make the startup for new mac users easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaults.yamlRelated PRs
Some problems...
if
~~shared, probably can't use certain libs as externalworkaround: propagate flag manually to important tpls in spec
^mfem~shared ^axom~shared ...