Skip to content

Cleanup smith spack pkg#1600

Merged
chapman39 merged 48 commits into
developfrom
task/chapman39/spack-pkg-cleanup
Jul 6, 2026
Merged

Cleanup smith spack pkg#1600
chapman39 merged 48 commits into
developfrom
task/chapman39/spack-pkg-cleanup

Conversation

@chapman39

@chapman39 chapman39 commented May 7, 2026

Copy link
Copy Markdown
Collaborator
  • update mfem, enzyme, spack and spack-packages
  • cleanup smith spack package in order to eventually push it up to spack
    • adds new smith version
    • removes outdated/ repeated sections
  • move forwarding spack variants to defaults.yaml
  • upgrade cmake to version 4+ on docker containers and mac mini (simplifies mac mini guide a bit)

Related PRs

Some problems...

if ~~shared, probably can't use certain libs as external

==> Error: failed to concretize `smith@develop+adiak+caliper+devtools+enzyme~openmp~~shared %[when='%fortran'] fortran=gcc@15 %[when='%c'] c=clang@19 %[when='%cxx'] cxx=clang@19 %[when='%mpi'] openmpi@5.0.9.clang_19` for the following reasons:
     1. Cannot build python, since it is configured `buildable:false` and no externals satisfy the request
     2. Cannot build py-sphinx, since it is configured `buildable:false` and no externals satisfy the request
     3. Cannot build lua, since it is configured `buildable:false` and no externals satisfy the request

workaround: propagate flag manually to important tpls in spec ^mfem~shared ^axom~shared ...

@chapman39 chapman39 self-assigned this May 7, 2026
@chapman39 chapman39 changed the base branch from develop to bugfix/chapman39/rm-dup-rpaths June 11, 2026 17:22
Base automatically changed from bugfix/chapman39/rm-dup-rpaths to develop June 11, 2026 22:02
@chapman39 chapman39 requested a review from tupek2 July 3, 2026 01:19
@chapman39 chapman39 changed the title WIP: Cleanup smith spack pkg Cleanup smith spack pkg Jul 3, 2026
@chapman39 chapman39 added the TPL Third-party libraries label Jul 3, 2026
Comment thread scripts/spack/configs/defaults.yaml Outdated
Comment thread cmake/smith-config.cmake.in Outdated
Comment thread scripts/docker/dockerfile_clang-19 Outdated
Comment thread scripts/docker/dockerfile_cuda-12 Outdated
Comment thread scripts/docker/dockerfile_gcc-14 Outdated
Comment thread scripts/spack/configs/defaults.yaml Outdated
Comment thread scripts/spack/configs/defaults.yaml
Comment thread scripts/spack/configs/defaults.yaml
Comment thread scripts/spack/configs/defaults.yaml
version("develop", branch="develop", submodules=True, preferred=True)
version("main", branch="main")
version("develop", branch="develop")
version("0.1.0", tag="v0.1.0", commit="cbe2e173eb1cbc36525ba454a386e4fe0b7e6440")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is going to be hard to release this to spack-packages unless our releases have actual releases from mfem/axom/etc.... not sure what to do with that given we track their develop so closely.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats a good point.. we'd have to wait until dependencies properly release the version we need, which might be hard to track

Comment thread scripts/spack/spack_repo/smith/packages/smith/package.py Outdated
Comment thread scripts/spack/spack_repo/smith/packages/smith/package.py Outdated
Comment thread scripts/spack/spack_repo/smith/packages/smith/package.py Outdated
Comment thread scripts/spack/spack_repo/smith/packages/smith/package.py Outdated
@white238

white238 commented Jul 3, 2026

Copy link
Copy Markdown
Member

Overall this looks great. Thanks for the hard work @chapman39 !

chapman39 and others added 3 commits July 6, 2026 10:39
@chapman39 chapman39 requested a review from white238 July 6, 2026 18:19

@btalamini btalamini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool that the Mac mini build can use the Homebrew cmake. That will make the startup for new mac users easier.

@chapman39 chapman39 mentioned this pull request Jul 6, 2026
@chapman39 chapman39 merged commit bd46202 into develop Jul 6, 2026
17 checks passed
@chapman39 chapman39 deleted the task/chapman39/spack-pkg-cleanup branch July 6, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

TPL Third-party libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants