fix(ldap): case-insensitive attribute lookup, request login attribute in search - #338
Merged
Conversation
… in search LDAP attribute names are case-insensitive (RFC 4512), but servers return them in their own canonical casing: openldap returns 'cn' for a requested 'CN', so the case-sensitive HashMap lookup failed with 'CN attribute not found' after successful credential verification. The search also only requested the CN attribute, so the login attribute (e.g. uid) was never returned and its lookup failed next. Verified end-to-end against openldap 2.6: valid credentials log in, wrong/empty passwords are rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same change as #296, rebased onto master after #271 landed. The only conflict was that both added a
testsmodule toldap.rs; the two sets of tests are now side by side. Authorship of the commit is unchanged.cnforCN)