fix: Preserve exclusions in leiningen plugin#234
Open
marcobiscaro2112 wants to merge 1 commit into
Open
Conversation
Carry exclusions metadata from dependencies when using antq as a leiningen plugin. Fixes liquidz#231.
liquidz
requested changes
Aug 15, 2023
liquidz
left a comment
liquidz
left a comment
Owner
There was a problem hiding this comment.
@marcobiscaro2112 Thank you for your contribution!
Overall the PR looks good.
Could you add a test case for exclutions to integration test?
https://github.com/liquidz/antq/blob/main/script/integration_test.sh
Contributor
|
Hmmm.... this one seems to fit in with lein plugin work which I'm already looking at. I can put it on my antq todo list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry exclusions metadata from dependencies when using antq as a leiningen plugin.
Fixes #231.