Repository navigation
Give the protocol page the WebSocket path and the token's other forms - #48
Merged
Merged
Conversation
ehfd
force-pushed
the
selkies-token-fragment
branch
from
October 1, 2026 03:13
a916141 to
527cfa2
Compare
ehfd
marked this pull request as ready for review
October 3, 2026 15:00
ehfd
marked this pull request as draft
October 3, 2026 15:18
ehfd
force-pushed
the
selkies-token-fragment
branch
from
October 5, 2026 07:25
527cfa2 to
ed6cdcf
Compare
ehfd
marked this pull request as ready for review
October 21, 2026 10:21
Contributor
Author
…n's other forms The pages document the session token in the fragment and /api/tokens since the 2.1.0 sync, but the protocol page still connected to the v1 images' websocket location, and left out a fragment token after a role or display keyword and the Selkies-Authorization header, which carries the master token for a caller behind a Basic login.
ehfd
force-pushed
the
selkies-token-fragment
branch
from
October 27, 2026 05:31
ff2b736 to
c7d66e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on
main, where the 2.1.0 sync (6ea2f4c, 07abf8d) already documents the token in the fragment,/api/tokensin place of the 8083 control port, theapilocation, the print spool's default,PAPERSIZE, and the interposer sockets inXDG_RUNTIME_DIR, so those changes are dropped. What the protocol page still lacked:<subfolder>api/websockets, where the page still had the v1 images'<subfolder>websocket.#display2-right&token=<token>.Selkies-Authorization;Authorizationis tried first.Tested:
mkdocs build --strictafter rebasing onmain(withdocs/requirements.txtand d2 0.9.0): no warnings or errors.stream_server.pytakes the master token fromSelkies-AuthorizationwhenAuthorizationdoes not carry it, and the web client'spage-url.jsreadstoken=beside a keyword in either order.main(3291323) behind the port 3000 server block of the baseimage'sroot/defaults/default.conf(master), with its placeholders filled asinit-nginxfills them, in nginx 1.31.6: in Chrome, Firefox, and WebKit,/#token=streams, the socket request isGET /api/websocketsofferingselkies, selkies.token.*and answered 101 withselkies, and no request line or Referer that nginx logged carries the token.POST /api/tokensthrough nginx answers 200. The same holds under a subfolder with the block'sauth_basiclines enabled, asPASSWORDenables them, behind a proxy that sets the container's Basic login on every request, as SealSkin's Caddy does.?token=streams as before.ghcr.io/linuxserver/webtop:ubuntu-kdeitself, running Selkiesmain(1251515) through the image's dev mode (DEV_MODE=selkies-dashboard): in Chrome 154, Firefox 156, and WebKit,/#token=streams the KDE desktop, the socket request isGET /api/websocketswith no query, and no line of the image's nginx access log or of the container's log carries the token.?token=streams as before.