[WIP] Refactor XAppStatusIcon backend handling, add client support for FDO's StatusNotifier #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StatusNotifier client support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor cleans up our XAppStatusIcon implementation, which had a fallback using GtkStatusIcon, to also implement StatusNotifierItem/AppIndicator if supported by the environment. This will allow use of XAppStatusIcon on desktops that lack either GtkStatusIcon or native XAppStatusIcon support (such as gnome-shell).
This is the opposite end of what our xapp-sn-watcher currently provides (which is a StatusNotiferWatcher/Host implementation.
It will end up having more or less the same limitations that GtkStatusIcon has (simple menus only, using dbusmenu for conversions).