Skip to content

feat: rewrite PopupHandle for Qt6 with Window popupType support#613

Closed
18202781743 wants to merge 1 commit intomasterfrom
popupwindow
Closed

feat: rewrite PopupHandle for Qt6 with Window popupType support#613
18202781743 wants to merge 1 commit intomasterfrom
popupwindow

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

  1. Rewrite DPopupWindowHandle to work natively with Qt6
  2. Support Popup.Window popupType with window decorations (radius,
    border, shadow, blur)
  3. Implement screen edge avoidance for popup windows
  4. Add close-on-focus-loss behavior through event filters
  5. Simplify architecture: remove DPopupWindowHandleImpl and DVtableHook
    usage
  6. Remove global PopupMode enum and forceWindowMode property
  7. Update DQuickWindowAttached to support QQuickPopup objects

Log: Rewrite PopupHandle to support popupType Window mode in Qt6

Influence:

  1. Test Popup with popupType: Window – verify window decorations
    (radius, border, shadow, blur)
  2. Test screen edge avoidance: open popups near screen edges and verify
    positioning
  3. Test close-on-click-outside: click outside popup and verify it closes
  4. Test close-on-focus-loss: switch to other window and verify popup
    closes
  5. Test nested popups (submenus) – verify correct screen assignment and
    flipping behavior
  6. Test window properties: windowRadius, borderWidth, borderColor,
    shadowRadius, shadowOffset, shadowColor
  7. Test translucentBackground and enableBlurWindow properties
  8. Test menu popup behavior – ensure no regressions in Menu popup
  9. Test with different screen configurations (multiple monitors,
    different DPI)
  10. Verify no crash when popup is destroyed

feat: 重写PopupHandle以支持Qt6的Window模式

  1. 重写DPopupWindowHandle以原生支持Qt6
  2. 支持Popup.Window弹窗类型,添加窗口装饰(圆角、边框、阴影、模糊)
  3. 实现弹窗窗口的屏幕边缘避让
  4. 通过事件过滤器实现失去焦点自动关闭
  5. 简化架构:移除DPopupWindowHandleImpl和DVtableHook的使用
  6. 移除全局PopupMode枚举和forceWindowMode属性
  7. 更新DQuickWindowAttached以支持QQuickPopup对象

Log: 重写PopupHandle支持popupType为Window模式

Influence:

  1. 测试Popup的popupType: Window模式 – 验证窗口装饰(圆角、边框、阴影、
    模糊)
  2. 测试屏幕边缘避让:在屏幕边缘打开弹窗,验证位置调整
  3. 测试点击外部关闭:点击弹窗外区域,验证弹窗关闭
  4. 测试失去焦点关闭:切换到其他窗口,验证弹窗关闭
  5. 测试嵌套弹窗(子菜单)– 验证正确的屏幕分配和翻转行为
  6. 测试窗口属性:windowRadius、borderWidth、borderColor、shadowRadius、
    shadowOffset、shadowColor
  7. 测试translucentBackground和enableBlurWindow属性
  8. 测试菜单弹窗行为 – 确保菜单弹窗没有回归问题
  9. 测试不同屏幕配置(多显示器、不同DPI)
  10. 验证弹窗销毁时不会崩溃

1. Rewrite DPopupWindowHandle to work natively with Qt6
2. Support Popup.Window popupType with window decorations (radius,
border, shadow, blur)
3. Implement screen edge avoidance for popup windows
4. Add close-on-focus-loss behavior through event filters
5. Simplify architecture: remove DPopupWindowHandleImpl and DVtableHook
usage
6. Remove global PopupMode enum and forceWindowMode property
7. Update DQuickWindowAttached to support QQuickPopup objects

Log: Rewrite PopupHandle to support popupType Window mode in Qt6

Influence:
1. Test Popup with popupType: Window – verify window decorations
(radius, border, shadow, blur)
2. Test screen edge avoidance: open popups near screen edges and verify
positioning
3. Test close-on-click-outside: click outside popup and verify it closes
4. Test close-on-focus-loss: switch to other window and verify popup
closes
5. Test nested popups (submenus) – verify correct screen assignment and
flipping behavior
6. Test window properties: windowRadius, borderWidth, borderColor,
shadowRadius, shadowOffset, shadowColor
7. Test translucentBackground and enableBlurWindow properties
8. Test menu popup behavior – ensure no regressions in Menu popup
9. Test with different screen configurations (multiple monitors,
different DPI)
10. Verify no crash when popup is destroyed

feat: 重写PopupHandle以支持Qt6的Window模式

1. 重写DPopupWindowHandle以原生支持Qt6
2. 支持Popup.Window弹窗类型,添加窗口装饰(圆角、边框、阴影、模糊)
3. 实现弹窗窗口的屏幕边缘避让
4. 通过事件过滤器实现失去焦点自动关闭
5. 简化架构:移除DPopupWindowHandleImpl和DVtableHook的使用
6. 移除全局PopupMode枚举和forceWindowMode属性
7. 更新DQuickWindowAttached以支持QQuickPopup对象

Log: 重写PopupHandle支持popupType为Window模式

Influence:
1. 测试Popup的popupType: Window模式 – 验证窗口装饰(圆角、边框、阴影、
模糊)
2. 测试屏幕边缘避让:在屏幕边缘打开弹窗,验证位置调整
3. 测试点击外部关闭:点击弹窗外区域,验证弹窗关闭
4. 测试失去焦点关闭:切换到其他窗口,验证弹窗关闭
5. 测试嵌套弹窗(子菜单)– 验证正确的屏幕分配和翻转行为
6. 测试窗口属性:windowRadius、borderWidth、borderColor、shadowRadius、
shadowOffset、shadowColor
7. 测试translucentBackground和enableBlurWindow属性
8. 测试菜单弹窗行为 – 确保菜单弹窗没有回归问题
9. 测试不同屏幕配置(多显示器、不同DPI)
10. 验证弹窗销毁时不会崩溃
@18202781743 18202781743 requested review from BLumia and mhduiy April 24, 2026 08:20
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @18202781743, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 deleted the popupwindow branch April 24, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants