sharedmem: accept relative buffer offsets - #41
Open
monperrus wants to merge 1 commit into
Open
Conversation
Signed-off-by: Martin Monperrus <martin.monperrus@gnieh.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept shared-memory request addresses expressed as offsets into the mapped
RMTFS region, while preserving support for the absolute physical addresses
handled by the current implementation.
Problem
On the MSM8909W downstream modem stack, sector requests arrive with values
such as
phys_offset=0x200: a zero-based offset into the RMTFS allocation.The current code always subtracts the mapping's physical base, treating the
value as an absolute physical address. The subtraction underflows and every
EFS transfer is rejected as out of bounds, preventing the modem from booting.
Change
mapped allocation.
overflow.
Completed Validation
sharedmem.cwith GCC for ARMv7 (-Wall -Wextra).