firehose: do not probe sector size when storage init is skipped - #297
Merged
konradybcio merged 1 commit intoJul 23, 2026
Merged
Conversation
firehose_try_configure() discovers the storage sector size by reading sector 1 of partition 0 with each candidate size. The provisioning path also runs this probe, and on a device with unprovisioned UFS the reads fail inside the programmer with "OPEN handle NULL and no error, weird": there is no LU 0 to open. The programmer does not recover from that failed open - the subsequent provisioning commit fails with "ufs_open(0, WLUN_DEV) failed for configure" and the device is left unprovisioned, while the same programmer, device and XML provision fine through QFIL, which sends no reads before the ufs tags. Gate the probe on skip_storage_init: the probe reads force the programmer to initialize the very storage the caller declared uninitialized, and provisioning - the only path passing skip_storage_init - expresses UFS geometry in kilobytes and never needs a sector size. Reported in the github issue [1]. [1] linux-msm#294 Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
igoropaniuk
force-pushed
the
fix/provision-sector-probe
branch
2 times, most recently
from
July 23, 2026 08:45
8d987c7 to
43b5ac8
Compare
igoropaniuk
changed the title
igoropaniuk
marked this pull request as ready for review
July 23, 2026 11:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firehose_try_configure() discovers the storage sector size by reading sector 1 of partition 0 with each candidate size. The provisioning path also runs this probe, and on a device with unprovisioned UFS the reads fail inside the programmer with "OPEN handle NULL and no error, weird": there is no LU 0 to open. The programmer does not recover from that failed open - the subsequent provisioning commit fails with "ufs_open(0, WLUN_DEV) failed for configure" and the device is left unprovisioned, while the same programmer, device and XML provision fine through QFIL, which sends no reads before the ufs tags.
Gate the probe on skip_storage_init: the probe reads force the programmer to initialize the very storage the caller declared uninitialized, and provisioning - the only path passing skip_storage_init - expresses UFS geometry in kilobytes and never needs a sector size. Reported in issue [1].
[1] #294