Add remaining required fields for certain payout countries

[JasonCWang]

No description provided.

[JasonCWang]

• Add remaining required fields for certain payout countries #237 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

✱ Stainless preview builds

This PR will update the grid SDKs with the following commit messages.

kotlin

feat(api): add swiftCode to HKD/MYR/THB/VND, add bankName/phoneNumber to IDR accounts

openapi

feat(api): add swiftCode to HKD/MYR/THB/VND, bankName/phoneNumber to IDR, remove sortCode

python

feat(api): add swift_code to HKD/IDR/MYR/THB/VND accounts, update IDR account fields

typescript

feat(api): add swiftCode to HKD/IDR/MYR/THB/VND, bankName/phoneNumber to IDR, remove sortCode

✅ grid-openapi studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅

✅ grid-python studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅

pip install https://pkg.stainless.com/s/grid-python/5fff4c93e32a6e1ec50fb618f13445fb0aeadb4e/grid-0.0.1-py3-none-any.whl

✅ grid-kotlin studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅

✅ grid-typescript studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅ → build ✅ → lint ✅ → test ✅

npm install https://pkg.stainless.com/s/grid-typescript/87f0c966797c82e08c70b36a0058bbb64eab0175/dist.tar.gz

---

This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-02-27 21:00:00 UTC

[matthappens]

qq - does the sample hong kong bank account number have a realistic number of digits?

[greptile-apps]

Greptile Summary

This PR adds swiftCode as a required field for HKD, IDR, MYR, THB, and VND account schemas, with proper validation patterns (8-11 characters, SWIFT/BIC format). For IDR specifically, it removes sortCode and adds bankName and phoneNumber as required fields.

Key changes:

• Added swiftCode with regex pattern ^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$ matching standard SWIFT/BIC format
• Improved field descriptions (e.g., "Name of the bank" instead of "The bank name of the bank")
• Added realistic examples for bank names and account numbers
• IDR-specific: replaced sortCode with swiftCode + added phoneNumber field for e-wallet payments

Critical issue found:

• All 5 modified schemas accidentally re-introduce the countries field that was intentionally removed in PR Remove countries field from AccountInfo schemas #233. This PR was branched before that removal. The branch needs to be rebased onto main to resolve this conflict.

Confidence Score: 2/5

• Not safe to merge due to unintended revert of previous changes
• The intended changes (adding swiftCode requirements and validation) are well-implemented and correct. However, this PR accidentally reverts the removal of the countries field from PR Remove countries field from AccountInfo schemas #233 because it was branched before that change. The branch needs to be rebased to avoid reintroducing the countries field.
• All 5 source schema files need the countries field removed from their required lists after rebasing

Important Files Changed

Filename	Overview
openapi/components/schemas/common/HkdAccountInfo.yaml	Added swiftCode requirement and examples; accidentally re-introduces countries field removed in PR #233
openapi/components/schemas/common/IdrAccountInfo.yaml	Added swiftCode, bankName, phoneNumber; removed sortCode; accidentally re-introduces countries field
openapi/components/schemas/common/MyrAccountInfo.yaml	Added swiftCode requirement and examples; accidentally re-introduces countries field removed in PR #233
openapi/components/schemas/common/ThbAccountInfo.yaml	Added swiftCode requirement and examples; accidentally re-introduces countries field removed in PR #233
openapi/components/schemas/common/VndAccountInfo.yaml	Added swiftCode requirement and examples; accidentally re-introduces countries field removed in PR #233

_{Last reviewed commit: 73e679c}

[greptile-apps]

_{7 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

openapi/components/schemas/common/HkdAccountInfo.yaml
Branch conflict: countries field was removed in PR #233 but reappears here. Rebase onto main to remove countries from required list.

This affects all 5 modified schemas (HKD, IDR, MYR, THB, VND).

- accountType
- paymentRails

Prompt To Fix With AI

This is a comment left during a code review.
Path: openapi/components/schemas/common/HkdAccountInfo.yaml
Line: 3

Comment:
Branch conflict: `countries` field was removed in PR #233 but reappears here. Rebase onto main to remove `countries` from required list.

This affects all 5 modified schemas (HKD, IDR, MYR, THB, VND).

```suggestion
- accountType
- paymentRails
```

How can I resolve this? If you propose a fix, please make it concise.