fixed the failing test browsermob-core/src/test/groovy/net/lightbody/bmp/proxy/NewHarTest.groovy testCaptureResponseCookiesInHar()#905
Open
kazurayam wants to merge 1 commit intolightbody:masterfrom
Conversation
…dy/bmp/proxy/newHarTest.groovy testCaptureResponseCookiesInHar()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is targeted to the current master branch of
2.1.6-SNAPSHOTversion.The test
browsermob-core/src/test/groovy/net/lightbody/bmp/proxy/NewHarTest.groovyfailed. The failure blocked me to accomplishmvn testandmvn install. I checked the source ofbrowsermob-core/src/test/groovy/net/lightbody/bmp/proxy/NewHarTest.groovyclass, methodtestCaptureResponseCookiesInHar(). I found a small problem to be fixed. See the issue in the forked repository in my GitHub accout for what I have done in detail:browsermob-core/src/test/groovy/net/lightbody/bmp/proxy/NewHarTest.groovytestCaptureResponseCookiesInHar()failed kazurayam/browsermob-proxy#3By my fix,
mvn testpasses,mvn installsucceeds.