fix: normalize IMMICH_BASE_URL to always include /api prefix - #9
Open
rokelvisar wants to merge 1 commit into
Open
fix: normalize IMMICH_BASE_URL to always include /api prefix#9rokelvisar wants to merge 1 commit into
rokelvisar wants to merge 1 commit into
Conversation
Immich v3 requires all API routes under /api/* (e.g. /api/search/smart). Users commonly set IMMICH_BASE_URL to just the server origin (https://photos.example.com) without /api suffix, causing 404 errors on search, asset listing, and other SDK calls. Add normalizeBaseUrl() that appends /api if missing, so both configurations work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Immich v3 moved all API routes under
/api/*(e.g./api/search/smart,/api/search/metadata). Users commonly setIMMICH_BASE_URLto just the server origin (e.g.https://photos.example.com) without the/apisuffix, causing 404 errors on SDK calls.The SDK defaults to
baseUrl: "/api", but when the user provideshttps://photos.example.com, that value replaces the default — so the SDK constructshttps://photos.example.com/search/smartinstead ofhttps://photos.example.com/api/search/smart.Fix
Added
normalizeBaseUrl()insrc/config.tsthat:/apiif the URL does not already end with itApplied in
getConfig()so bothhttps://photos.example.comandhttps://photos.example.com/apiwork correctly.Examples
https://photos.example.comhttps://photos.example.com/apihttps://photos.example.com/https://photos.example.com/apihttps://photos.example.com/apihttps://photos.example.com/apihttp://localhost:2283http://localhost:2283/apiVerification
npm run build)normalizeBaseUrledge cases