Skip to content

refactor: adopt effect-operator-kit behind golden contract tests - #6

Merged
solomonneas merged 11 commits into
masterfrom
feat/effect-kit-adoption
Jul 12, 2026
Merged

refactor: adopt effect-operator-kit behind golden contract tests#6
solomonneas merged 11 commits into
masterfrom
feat/effect-kit-adoption

Conversation

@solomonneas

Copy link
Copy Markdown
Collaborator

Adopts effect-operator-kit for the duplicated operator skeleton, behind golden contract tests written before any conversion. Same recipe as lidless-labs/n8nctrl#7.

Order of operations

  1. Golden contract tests first: programmatic CLI contracts (run() rejects with original error identity on client construction failure), confirm-gated writes make zero client calls, SDK-owned auth and transport pinned unchanged (the kit HTTP layer was deliberately not adopted here), existing retry helper semantics pinned exactly, CLI exit codes and stderr text, result shape stability.
  2. Kit installed from GitHub (prepare builds on install), then adoption slices with every exported name, signature, and observable behavior frozen. Where kit semantics differ from this repo, the repo behavior wins via wrapping.
  3. Review pass before merge, findings fixed with exact regression tests: pinned the write-gate error text and gate order, and replaced parse-then-assert golden checks with exact raw payload text pins so serialization drift is visible.

Verification

  • Full suite, typecheck, and build green at every step
  • Zero golden-test failures across the adoption

@solomonneas
solomonneas merged commit 008a41e into master Jul 12, 2026
2 checks passed
@solomonneas
solomonneas deleted the feat/effect-kit-adoption branch July 12, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant