Repository navigation
android: implement previously stubbed retro_vfs_file_rename_saf - #19966
Open
omar-sobhy wants to merge 1 commit into
Open
omar-sobhy wants to merge 1 commit into
omar-sobhy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Android with the current nightly build, attempting to write save states to an Android SAF path can fail. The expectation is that a temporary save state file will first be created, then it will be moved onto the existing save state file (if any exists). Currently, only the first part works -- the new file is never moved to the correct location. This is because moving the file relies on the stubbed out
retro_vfs_file_rename_saffunction, which currently simply returns -1.This PR implements
retro_vfs_file_rename_saf. It's just a thin wrapper doing a JNI call toVfsImplementationSaf#renameSafFile.