Inplace Color Augmentations (RandomBrightness, RandomContrast, RandomSaturation)#162
Merged
GuillaumeLeclerc merged 3 commits intolibffcv:v1.0.0from Mar 2, 2022
Jasonlee1995:color_aug
Merged
Inplace Color Augmentations (RandomBrightness, RandomContrast, RandomSaturation)#162GuillaumeLeclerc merged 3 commits intolibffcv:v1.0.0from Jasonlee1995:color_aug
GuillaumeLeclerc merged 3 commits intolibffcv:v1.0.0from
Jasonlee1995:color_aug
Conversation
Not include hue
Collaborator
GuillaumeLeclerc
left a comment
GuillaumeLeclerc
left a comment
There was a problem hiding this comment.
Looks very good. There is another PR (#154 ) that intersects with this one. Maybe we should merge the two implementations ?
Collaborator
|
#154 is still a WIP so I will merge this one in the meantime. Thank you for the work! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the advices from closed pull request, change out-place to in-place.
(speed improved)
Lack of my ability, augmentations don't contain adjusting hue and are divided into 3 parts with RandomBrightness, RandomContrast, RandomSaturation.
To avoid errors, I changed some of the methods which occur error on my env.
(changing torch unsqueeze, expand operations to numpy expand_dims, repeat operations occurs error)