Skip to content

[WIP] V1.0.0#160

Merged
GuillaumeLeclerc merged 54 commits intomainfrom
v1.0.0
Mar 3, 2023
Merged

[WIP] V1.0.0#160
GuillaumeLeclerc merged 54 commits intomainfrom
v1.0.0

Conversation

@GuillaumeLeclerc
Copy link
Collaborator

@GuillaumeLeclerc GuillaumeLeclerc commented Feb 17, 2022

Track progress for the next release

kangig94 and others added 22 commits January 23, 2022 20:34
@kangig94
declare dllexport and types in libffcv.cpp
1dee270
@kangig94
use cdll.msvcrt equivalent to libc.so.6
e760d6b
@kangig94
add pkgconfig functions to support windows build
4026cc9
@kangig94
Add installation process in Windows to README
71d05af
@kangig94
Fix to not use np.array().view in finalize writer, as windows throws …
bdeb248 
…error
@kangig94
Add dependency cupy-cuda to install on Windows
444e0c5
@kangig94
Merge branch 'main' into build-Windows
8274733
@GuillaumeLeclerc
[BUG] all augmentation pipeline were on the same GPU
b7efbe0 
- resolves #114
@GuillaumeLeclerc
Merge pull request #115 from libffcv/resolves_114
f9e8c12 
[BUG] all augmentation pipeline were on the same GPU
@GuillaumeLeclerc
Add TorchTensorField
0dfcbaa 
- Resolves #101
@GuillaumeLeclerc
Merge pull request #116 from libffcv/resolves_101
45f1274 
Add TorchTensorField
@GuillaumeLeclerc
Merge remote-tracking branch 'origin/main' into new_codegen
9758f72
@GuillaumeLeclerc
New Graph based codegen pipeline
f8baf22 
- A lot of tests are failing still but it's a first step
@GuillaumeLeclerc
Support for default pipelines in the new Graph implementation
2ff9a9d
@GuillaumeLeclerc
All tests passing with the Graph backend
307ffe0
@GuillaumeLeclerc
Fix memcpy when using other than uint8
aa56c32 
- Resolves #123
- Include unit test
@numpee
Add custom traversal order functionality
9bd7114
@GuillaumeLeclerc
Fix bug (multiple allocation queries was incorrect)
17f9e21
@GuillaumeLeclerc
Merge pull request #141 from numpee/custom_traversal
8a37c74 
Add custom traversal order functionality
@Jasonlee1995
Add color jitter augmentation
b207f1d 
Not include hue
@Jasonlee1995
Apply on init
71eb9f3
@GuillaumeLeclerc
Warn users when using non FFCV transforms on the CPU
2454ff2 
- Resolves #127
@GuillaumeLeclerc GuillaumeLeclerc changed the title V1.0.0 [WIP] V1.0.0 Feb 17, 2022
@GuillaumeLeclerc GuillaumeLeclerc added this to the v1.0.0 milestone Feb 17, 2022
@ashertrockman ashertrockman mentioned this pull request Jul 12, 2022
Open
15 tasks
@alexmyczko
Copy link

alexmyczko commented Jul 15, 2022

Can't wait for more releases...

@alexmyczko
Copy link

alexmyczko commented Oct 31, 2022

how far is a next release tag? possible within two months?

@ashertrockman
Copy link

ashertrockman commented Feb 28, 2023

@andrewilyas @GuillaumeLeclerc Are you still interested in merging #154 into V1.0.0? For what it's worth: while I didn't finish the checklist in the PR, some colleagues and I have been using it successfully for a long time. Let me know if there's anything I could do to make this happen.

@andrewilyas
Copy link
Contributor

andrewilyas commented Mar 1, 2023

Hi @ashertrockman ! My thought was to merge v1.0 -> master ASAP and update on PyPI, and then merge in this and grayscale support (#226) into a v1.1, does that sound good?

BTW, are there tests for the new augmentations?

@andrewilyas andrewilyas marked this pull request as ready for review March 1, 2023 20:39
@ashertrockman
Copy link

ashertrockman commented Mar 2, 2023

Yeah, that sounds good to me. There are tests here: https://github.com/libffcv/ffcv/blob/0fa3d7c8a041fec7348025afafe6e4f6fff60f33/tests/test_rand_aug.py. My goal was to very closely replicate the RandAugment implementation in TorchVision, so most of the tests use it as a baseline.

@andrewilyas
Copy link
Contributor

andrewilyas commented Mar 3, 2023

Amazing! This should be super easy to merge into v1.1 then. I'm planning on uploading v1.0 to PyPI tonight!

@GuillaumeLeclerc GuillaumeLeclerc merged commit 700bdf3 into main Mar 3, 2023
@hmgxr128 hmgxr128 mentioned this pull request Jun 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ashertrockman ashertrockman ashertrockman left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

9 participants

@GuillaumeLeclerc @alexmyczko @ashertrockman @andrewilyas @kangig94 @numpee @Jasonlee1995 @dskhudia @yvsriram