More coverage for PointLocator out_of_mesh_mode #4365
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwpeterson
approved these changes
Jan 13, 2026
Member
jwpeterson
left a comment
jwpeterson
left a comment
There was a problem hiding this comment.
Coverage says -3 hits/+3 misses after adding a new test?
Member
Author
|
The coverage decrease was a fluke, but yeah, the coverage increase is only 3 lines. I expanded the testing a little bit, but now it looks like I may need to kick something to get past the "inconsistent report tags"; I'll try rebasing. |
|
Job Test 32bit on 5620291 : invalidated by @roystgnr |
Experimenting with ChatGPT Codex led it to suggest that this was "low hanging fruit" for adding libMesh test coverage. I didn't like its suggestion for a new test so I wrote this instead.
roystgnr
force-pushed
the
out_of_mesh_coverage
branch
from
5620291 to
ea787db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimenting with ChatGPT Codex led it to suggest that this was "low hanging fruit" for adding libMesh test coverage. I didn't like its suggestion for a new test so I wrote this instead.