fix(controls): Fix LeftFluent nav item hover invisible in Light theme#1731
Open
ACbye wants to merge 1 commit into
Open
fix(controls): Fix LeftFluent nav item hover invisible in Light theme#1731ACbye wants to merge 1 commit into
ACbye wants to merge 1 commit into
Conversation
…lepoco#1729) Changed NavigationViewItemBackgroundSelectedLeftFluent to reference SubtleFillColorSecondary instead of ControlFillColorDefault, and increased SubtleFillColorSecondary opacity from 3.5% to 7.84% for perceptual parity with Dark theme hover feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
LeftFluent NavigationViewItem hover has no visible feedback in Light theme.
The IsMouseOver trigger and the selected brush both reference
ControlFillColorDefault,which resolves to
#B3FFFFFF(70% white) in Light theme. Overlayed on the#FAFAFAapplication background, the result is
#FEFEFE— a delta of only +4, imperceptible.Additionally,
SubtleFillColorSecondaryis#09000000(3.5% black), causing allSubtleFill-dependent controls to have very weak hover feedback in Light theme,
while Dark theme achieves +13 with the same token name.
Fixes #1729
What is the new behavior?
NavigationViewItemBackgroundSelectedLeftFluentreferencesSubtleFillColorSecondaryinstead ofControlFillColorDefaultSubtleFillColorSecondaryopacity increased from 3.5% (#09000000) to 7.84% (#14000000) for perceptual parity with Dark theme's +13#FEFEFE(Δ+4)#E6E6E6(Δ−20)#2D2D2D(Δ+13)Other information
Only
Light.xaml(2 lines) changed. Dark theme and Left/LeftMinimal modes are unaffected.