fix: SetWindowChrome ResizeBorderThickness for non-resizable modes#1728
Open
xyliteee wants to merge 1 commit into
Open
fix: SetWindowChrome ResizeBorderThickness for non-resizable modes#1728xyliteee wants to merge 1 commit into
xyliteee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
PR #1719 added a
ResizeModecheck inTitleBar.GetWindowBorderHitTestResult()to prevent resizing whenResizeModeisNoResizeorCanMinimize. However, this was only a partial fix — the root cause is inFluentWindow.SetWindowChrome(), whereResizeBorderThicknessis incorrectly set to4forCanMinimizemode.Because
WindowChromehandlesWM_NCHITTESTindependently ofTitleBar'sHwndSourceHook, theTitleBarfix alone cannot fully prevent resizing inCanMinimizemode. The window borders remain resizable viaWindowChrome.ResizeBorderThickness.Related: #1719
What is the new behavior?
FluentWindow.SetWindowChrome()now only setsResizeBorderThickness = 4whenResizeModeisCanResizeorCanResizeWithGripCanMinimizeandNoResizenow correctly getResizeBorderThickness = 0, preventing unintended window resizing at theWindowChromelevelOther information
This PR supersedes / completes the fix started in #1719. The previous PR worked around the symptom in
TitleBar; this PR fixes the root cause inFluentWindow.Minimal repro XAML (before fix — window borders remain resizable):