Skip to content

feat(controls): Add TimePicker control#1499

Open
OneEyedOlaf wants to merge 4 commits into
lepoco:mainfrom
OneEyedOlaf:Add_TimePicker
Open

feat(controls): Add TimePicker control#1499
OneEyedOlaf wants to merge 4 commits into
lepoco:mainfrom
OneEyedOlaf:Add_TimePicker

Conversation

@OneEyedOlaf

@OneEyedOlaf OneEyedOlaf commented Jul 30, 2025

Copy link
Copy Markdown

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

The library currently lacks a dedicated TimePicker control.

What is done?

  1. Basic control structure and logic.
  2. A functional UI that works correctly in the light theme.

What is the new behavior?

This PR introduces a new TimePicker control.

Other information

As I am new to WPF and not yet fully familiar with the wpf-ui styling and brush system, I have only implemented the basic functionality and a simple UI for the light theme.

@github-actions github-actions Bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request gallery WPF UI Gallery dotnet release labels Jul 30, 2025
@pomianowski pomianowski linked an issue Nov 7, 2025 that may be closed by this pull request
@pomianowski pomianowski changed the title Add TimePickerControl feat(controls): Add TimePickerControl Nov 7, 2025
@pomianowski pomianowski changed the title feat(controls): Add TimePickerControl feat(controls): Add TimePicker control Nov 7, 2025
@pomianowski pomianowski marked this pull request as ready for review November 7, 2025 13:16
<ui:TimePicker
Width="300"
AcceptButtonText="OK"
DismissButtonText="Cancle"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is only the gallery page, but: typo

@chucker

chucker commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Thanks for your contribution; this is a great start. A few things I've noticed:

  • the popup doesn't properly obscure the background. Notice how I can read the word "Source code":
image
  • when no value has been picked, WPF UI Gallery used to show placeholder text, which I no longer see with this PR. That also matches how WinUI 3 Gallery shows the control.
image
  • the list boxes should be taller. WinUI shows 9 items; this PR shows 3.
  • scroll arrow-like buttons should be added. Here's how WinUI shows those (on hover of the respective column):
image
  • to make the popup less jarring, the control's sections should align with it (i.e., space the two to three sections out), and the popup itself should vertically align with the control), the way WinUI does it:
image image
  • WPF UI doesn't yet support the "subtle" style, so we can't use that, but maybe the buttons should use icons instead of labels:
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

controls Changes to the appearance or logic of custom controls. dotnet gallery WPF UI Gallery PR Pull request release ⭐ top pull request Top pull request. styles Topic is related to styles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hope to add DatePicker control support for time selection

3 participants