fix: omni size filtering, .completed sentinel backfill, disk space pre-check (#2201 #1341 #1999 #1003)#2463
Open
bong-water-water-bong wants to merge 1 commit into
Conversation
…e-check Three fixes in model_manager.cpp: 1. lemonade-sdk#2201 — apply size-vs-RAM filter to omni collections instead of unconditionally passing them through (was skipping all filtering) 2. lemonade-sdk#1341/lemonade-sdk#1999 — add .completed sentinel to is_checkpoint_path_complete() with automatic backfill for pre-existing downloads. Prevents both false positives (sentinel without GGUF) and false negatives (no sentinel on old downloads causing re-download loops after upgrade) 3. lemonade-sdk#1003 — add proactive disk-space check before download_from_manifest() in the HuggingFace download path, mirroring the one already inside download_from_manifest()
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes in
model_manager.cpp:1. Fix #2201 — Size filter omni collections
Collections (LMX-Omni-52B-Halo, etc.) had an unconditional
continuein the filtering loop that skipped ALL checks including size-vs-RAM. Now collections skip only the recipe-support check but still get size-filtered. Models like LMX-Omni-52B-Halo (44 GB) will be hidden on systems with insufficient RAM.2. Fix #1341/#1999 — .completed sentinel with backfill
Added a
.completedsentinel check tois_checkpoint_path_complete()as the authoritative download-complete marker. Includes automatic backfill: if a directory has content, no manifest, and no partial files but lacks.completed, the sentinel is written and the directory is accepted. This prevents both:3. Fix #1003 — Disk space pre-check before HF download
Added a proactive
fs::space()check before starting the HuggingFace download, mirroring the one already indownload_from_manifest(). Catches disk-full conditions before any data is written, preventing system-level crashes on low-disk systems.