fix: add gfx1152 (Krackan APU) to whispercpp:rocm and vllm:rocm (#2002)#2461
Open
bong-water-water-bong wants to merge 2 commits into
Open
fix: add gfx1152 (Krackan APU) to whispercpp:rocm and vllm:rocm (#2002)#2461bong-water-water-bong wants to merge 2 commits into
bong-water-water-bong wants to merge 2 commits into
Conversation
…rted GPUs (lemonade-sdk#2002) gfx1152 (Radeon 840M/860M, Krackan Point) was already supported by llamacpp:rocm and sd-cpp:rocm in RECIPE_DEFS, but was missing from whispercpp:rocm and vllm:rocm, causing 'Unsupported GPU: gfx1152' errors when trying to install those backends on Krackan APU hardware.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
engine::whispercpp
…llback (lemonade-sdk#1385) Model downloads use libcurl which blocks in a system call. The existing SIGINT handler only set a graceful-shutdown flag, but in-progress downloads would continue uninterrupted until completion. Fix: 1. Add a global atomic flag g_download_cancelled in http_client.cpp 2. Check it in the libcurl progress callback (called during transfer) 3. Set it from the SIGINT handler in main.cpp When Ctrl+C is pressed during a model download: - libcurl's progress callback detects g_download_cancelled - Returns non-zero to abort the transfer - download_attempt returns cancelled=true - The partial file is preserved for later resume
Contributor
|
I think your agent pulled in some unrelated changes (8c22dea), relating to canceling downloads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2002 — Krackan APU (Radeon 840M/860M, gfx1152) shows "Unsupported GPU: gfx1152" when trying to install whispercpp:rocm or vllm:rocm.
Root Cause
gfx1152 was already in
llamacpp:rocmandsd-cpp:rocmRECIPE_DEFS, but missing from whispercpp:rocm and vllm:rocm.Fix
Add "gfx1152" to the amd_gpu device constraints for whispercpp:rocm and vllm:rocm.