fix(isolated-review): report tool_execution events as live progress - #17
Merged
Merged
Conversation
Tool-only stretches (reading diff, rg, rules) previously emitted zero progress, freezing the host UI for minutes mid-review. - parse tool_execution_start (args preview) and tool_execution_end(isError) from the reviewer JSON stream alongside message_end assistant text - args preview picks file_path/path/command/query/pattern/url/skill, flattened and capped at 120 chars - +5 unit tests + 1 integration test; bun test 256 pass, tsc clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
04-review isolated_review 运行期 UI 静止（无动态滚动）的根因：progress 只解析
message_endassistant 文本，reviewer 连续调工具期间零输出。tool_execution_start（args 摘要预览）与tool_execution_end(isError)，与message_end文本并列推送变更范围
2 files, +103/-1
测试
bun test：256 pass / 0 fail（+5 单测 +1 集成）bunx tsc --noEmit：0 error