Skip to content

feat: expand c abbr to run claude in toolbox container when outside toolbx - #150

Merged
dclong merged 2 commits into
mainfrom
push-vzonxkpulssl
Oct 1, 2026
Merged

dclong merged 2 commits into
mainfrom
push-vzonxkpulssl

Conversation

@dclong

@dclong dclong commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • feat: expand c abbr to run claude in toolbox container when outside toolbx
  • feat(abbr): expand agy commands inside toolbox container

Changed files

Added

  • functions/_expand_agy.fish (+15/-0)
  • functions/_expand_agy_safe.fish (+3/-0)
  • functions/_expand_agy_unsafe.fish (+3/-0)
  • functions/_expand_claude.fish (+9/-0)
    Modified
  • config.fish (+5/-5)

Commits

  • eb8e8fd feat: expand c abbr to run claude in toolbox container when outside toolbx
  • 2d1e52c feat(abbr): expand agy commands inside toolbox container

@dclong

dclong commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor Author

Claude finished @dclong's task in 14s —— View job


Code review: PR #150

No blocking issues found. tbx exists in functions/tbx.fish and supports version jupyterhub-ds. The abbr --function wiring is correct, and the new helpers use the _ prefix and one-function-per-file layout from CLAUDE.md. I didn't run fish_indent or fish -n.

Non-blocking suggestions:

  • functions/_expand_agy.fish:5: set cmd "agy --dangerously-skip-permissions" is a single quoted string. That works for echo, but a list (set cmd agy --dangerously-skip-permissions) would be cleaner.
  • functions/_expand_claude.fish and functions/_expand_agy.fish repeat the toolbx hostname check and container lookup. You could pull that into a shared helper later.
  • functions/_expand_claude.fish:2: the comment is redundant.
  • The expansion calls tbx version on every abbreviation trigger, outside toolbx. That's a small latency cost.

AUTO_MERGE_APPROVED

@dclong
dclong merged commit c67a73b into main Oct 1, 2026
3 checks passed
@dclong
dclong deleted the push-vzonxkpulssl branch October 2, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant