chore: bump llama.cpp to b9780#19
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
github-actions
Bot
force-pushed
the
automation/bump-llama-cpp
branch
from
fcc8744 to
37a6ad0
Compare
github-actions
Bot
changed the title
github-actions
Bot
force-pushed
the
automation/bump-llama-cpp
branch
from
37a6ad0 to
83f441d
Compare
github-actions
Bot
changed the title
github-actions
Bot
force-pushed
the
automation/bump-llama-cpp
branch
from
83f441d to
3892492
Compare
github-actions
Bot
changed the title
github-actions
Bot
force-pushed
the
automation/bump-llama-cpp
branch
from
3892492 to
6dd1933
Compare
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llama.cpp update
b9699b9780Upstream changelog
Release notes for b9780
Details
vulkan: fail the build when a shader fails to compile (#24450)
vulkan-shaders-gen did not detect shader-compile subprocess failures, so a
broken libggml-vulkan could be produced while the build reported success and
the breakage only surfaced at run time. execute_command() discarded the child
exit code (POSIX waitpid passed nullptr for status; the Windows branch never
called GetExitCodeProcess) and string_to_spv decided success only from whether
stderr was empty, so a non-zero exit with empty stderr, or a subprocess that
failed to launch, was treated as success.
Return the child exit code from execute_command() (WEXITSTATUS on POSIX,
GetExitCodeProcess on Windows), treat a non-zero exit or non-empty stderr or a
launch exception as a failure, and record it in an atomic flag. main() checks
the flag after process_shaders() and returns EXIT_FAILURE before writing the
output files, so the build stops instead of emitting a broken backend.
Fixes #24393
Signed-off-by: liminfei-amd 91481003+liminfei-amd@users.noreply.github.com
Address review feedback on #24450:
instead of .store()/.load(); the flag stays atomic because the worker
threads in process_shaders() set it concurrently.
child _exit()s after execvp and the parent returns (fork()<0 throws); on
Windows the block returns the exit code.
Signed-off-by: liminfei-amd 91481003+liminfei-amd@users.noreply.github.com
Signed-off-by: liminfei-amd 91481003+liminfei-amd@users.noreply.github.com
macOS/iOS:
Linux:
Android:
Windows:
openEuler:
UI:
Commit range
Commits from b9699 to b9780 (first 80)
9724f66)24bba7b)968c438)552258c)1078621)2083217)0802307)e1efd09)fe7c8b2)7b6c5a2)d2c6795)060ce1b)32eddaf)a6b3260)40f3aaf)3a3edc9)db52540)8141e73)80452d6)5bd21b8)1868af1)5fd2dc2)159d093)b14e3fb)e2e7a9b)38724ab)8c2d6f6)0d2d9cc)fabde3b)175147e)e475fa2)4b48a53)2b686a9)f449e05)f4043fe)37a77fb)796f41b)67e9fd3)e27f308)8452824)75f460a)84de01a)4a80943)c576070)063d9c1)d789527)8a118ee)d6d8995)bfa3219)2f89acc)bf53382)0d135df)bddfd2b)7c082bc)52b3df0)libandroid-spawnfor building in termux (#21812) (0ef6f06)d0f9d2e)37957e8)f8cc15f)099b579)6ee0f65)721354f)9c0ac88)dec5ca5)23ee879)73618f2)035cd8f)7c90850)a3900a6)c926ad0)75ad0b2)0eb874d)c560636)92e854a)72a9269)be4a6a6)ac4105d)88636e1)ef9c13d)00139b6)Web bridge review focus
Please pay extra attention to upstream changes touching:
Validation
Automation behavior
This PR is managed from the stable branch
automation/bump-llama-cpp. If another llama.cpp release appears before merge, the scheduled workflow updates this same PR instead of opening a duplicate. The workflow skips if a non-automation PR already changesllama_cpp.version.